impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5589: change "set" in impala-shell to show empty string for unset query options
Date Tue, 05 Sep 2017 16:46:57 GMT
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-5589: change "set" in impala-shell to show empty string for unset query
options
......................................................................


Patch Set 2: Code-Review+2

(2 comments)

http://gerrit.cloudera.org:8080/#/c/7886/2//COMMIT_MSG
Commit Message:

PS2, Line 39: the simply empty string approach
extra word?


PS2, Line 44: beneift
typo


-- 
To view, visit http://gerrit.cloudera.org:8080/7886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I86bc06a58d67b099da911293202dae9e844c439b
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Philip Zeyliger <philip@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <philip@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message