impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5867: Fix bugs parsing 2-digit year
Date Tue, 05 Sep 2017 16:20:35 GMT
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-5867: Fix bugs parsing 2-digit year
......................................................................


Patch Set 3:

(1 comment)

The fact that we found 3 issues in this code (after IMPALA-3894) makes me nervous. I didn't
look in close detail yet, but given 2.10 is looming and I'm worried about all the subtleties
of the Timestamp code, I think we should consider reverting 5797f859692ced6f30a790568b29669c663fa65c
for 2.10 and getting this fix into master afterwards. I think we need to think about ways
to get more test coverage here to make sure we don't have other crashes or incorrect results
in other corner cases.

http://gerrit.cloudera.org:8080/#/c/7910/3//COMMIT_MSG
Commit Message:

PS3, Line 22: 1. A date without month/day is considered invalid. Note this is
            :    different from Hive.
why don't we do the same thing as hive?


-- 
To view, visit http://gerrit.cloudera.org:8080/7910
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4f430caea88b6c33f8050a1984ee0ee32ecb0a1
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tianyi Wang <twang@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <twang@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message