impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] [security] avoid kerberos ticket renewal and only reacquire
Date Fri, 01 Sep 2017 21:29:54 GMT
Michael Ho has posted comments on this change.

Change subject: [security] avoid kerberos ticket renewal and only reacquire
......................................................................


Patch Set 4: Code-Review+2

(1 comment)

I didn't look too deeply into the change given it's a mostly clean backport. The conflict
is expected and the resolution looks reasonable to me.

http://gerrit.cloudera.org:8080/#/c/7898/4/be/src/kudu/security/init.cc
File be/src/kudu/security/init.cc:

PS4, Line 187: reacqusition
nit: typo: reacquisition. Feel free to ignore and merge as-is. Fixing it may cause merge conflict
in the future.


-- 
To view, visit http://gerrit.cloudera.org:8080/7898
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e5225de332ba785e3a73014b8418cfd4059fe07
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <todd@apache.org>
Gerrit-HasComments: Yes

Mime
View raw message