impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Impala Public Jenkins (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5873: Check for existence of sync file range()
Date Fri, 01 Sep 2017 00:35:52 GMT
Impala Public Jenkins has submitted this change and it was merged.

Change subject: IMPALA-5873: Check for existence of sync_file_range()
......................................................................


IMPALA-5873: Check for existence of sync_file_range()

On some legacy platforms, the system call sync_file_range()
is not defined. Some Kudu code calls it unconditionally
on Linux platforms. Let's check for its existence and use
the workaround already defined for non-Linux platforms.

Testing done: ran packaging build on Centos55. Failed consistently before.

Change-Id: I9e398085ebd00c23fd1f29f9253d9c257e0c5442
Reviewed-on: http://gerrit.cloudera.org:8080/7923
Reviewed-by: Michael Ho <kwho@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/CMakeLists.txt
M be/src/common/config.h.in
M be/src/kudu/util/env_posix.cc
3 files changed, 4 insertions(+), 2 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Michael Ho: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/7923
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9e398085ebd00c23fd1f29f9253d9c257e0c5442
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>

Mime
View raw message