Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 7B23D200CF3 for ; Wed, 30 Aug 2017 00:26:00 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 79761167BA7; Tue, 29 Aug 2017 22:26:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id BFB53167BA5 for ; Wed, 30 Aug 2017 00:25:59 +0200 (CEST) Received: (qmail 35655 invoked by uid 500); 29 Aug 2017 22:25:59 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 35643 invoked by uid 99); 29 Aug 2017 22:25:58 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 29 Aug 2017 22:25:58 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id F15181A5008 for ; Tue, 29 Aug 2017 22:25:57 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id mLqBhHvD-MtS for ; Tue, 29 Aug 2017 22:25:57 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 765E2610F2 for ; Tue, 29 Aug 2017 22:23:51 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v7TMNnn0029965; Tue, 29 Aug 2017 22:23:49 GMT Date: Tue, 29 Aug 2017 22:23:49 +0000 From: "Alex Behm (Code Review)" To: Marcel Kornacker , impala-cr@cloudera.com, reviews@impala.incubator.apache.org Message-ID: Reply-To: alex.behm@cloudera.com X-Gerrit-MessageType: newchange Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5850=3A_Cast_sender_partition_exprs_under_unions=2E=0A?= X-Gerrit-Change-Id: I0aa801bcad8c2324d848349c7967d949224404e0 X-Gerrit-ChangeURL: X-Gerrit-Commit: 77619bc2c3444b2c87e4adfd757eabf7d6d6b621 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Tue, 29 Aug 2017 22:26:00 -0000 Alex Behm has uploaded a new change for review. http://gerrit.cloudera.org:8080/7884 Change subject: IMPALA-5850: Cast sender partition exprs under unions. ...................................................................... IMPALA-5850: Cast sender partition exprs under unions. For a series of partitioned joins within the same fragment we must cast the sender partition exprs of exchanges to compatible types. Otherwise, the hashes generated for identical partition values may differ among senders leading to wrong results. The bug was that this casting process was only performed for fragments that are hash-partitioned. However, a union produces a fragment with RANDOM partition, but the union could still contain partitioned joins whose senders need to be cast appropriately. The fix is to add casts regardless of the fragment's data partition. Testing: - Core/hdfs run passed - Added a new regresion test Change-Id: I0aa801bcad8c2324d848349c7967d949224404e0 --- M fe/src/main/java/org/apache/impala/planner/PlanFragment.java M testdata/workloads/functional-query/queries/QueryTest/joins.test 2 files changed, 83 insertions(+), 35 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/84/7884/1 -- To view, visit http://gerrit.cloudera.org:8080/7884 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0aa801bcad8c2324d848349c7967d949224404e0 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm