Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B1889200CF4 for ; Sun, 20 Aug 2017 03:11:44 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id ADD521621B8; Sun, 20 Aug 2017 01:11:44 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id F21B6161E2A for ; Sun, 20 Aug 2017 03:11:43 +0200 (CEST) Received: (qmail 12978 invoked by uid 500); 20 Aug 2017 01:11:43 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 12941 invoked by uid 99); 20 Aug 2017 01:11:40 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 20 Aug 2017 01:11:40 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 39FA71807ED for ; Sun, 20 Aug 2017 01:11:40 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id ddwas8adM-S2 for ; Sun, 20 Aug 2017 01:11:36 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 99C915F1B3 for ; Sun, 20 Aug 2017 01:11:36 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v7K1BYaf001153; Sun, 20 Aug 2017 01:11:34 GMT Date: Sun, 20 Aug 2017 01:11:34 +0000 From: "Michael Ho (Code Review)" To: Adar Dembo , Marcel Kornacker , impala-cr@cloudera.com, reviews@impala.incubator.apache.org Message-ID: Reply-To: kwho@cloudera.com X-Gerrit-MessageType: newchange Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_tidy=3A_enable_rule_for_constant_naming=0A?= X-Gerrit-Change-Id: I7971659ef3152580d44d6ddfb18be7ebf41052c7 X-Gerrit-ChangeURL: X-Gerrit-Commit: 9a32fe13016025fbe37c80512d046b861e511edb MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Sun, 20 Aug 2017 01:11:44 -0000 Hello Adar Dembo, Kudu Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7740 to review the following change. Change subject: tidy: enable rule for constant naming ...................................................................... tidy: enable rule for constant naming This enables the rule that constants should be named kFooBar and fixes the cases where we didn't adhere to this. The fixes were started using clang-tidy --fix, but it wasn't very good at finding all references, so I did some by-hand tweaking to get it to compile after that. I left a few aberrations in gutil, etc, but this should be at least a good cleanup. Change-Id: I7971659ef3152580d44d6ddfb18be7ebf41052c7 Reviewed-on: http://gerrit.cloudera.org:8080/7158 Reviewed-by: Adar Dembo Tested-by: Kudu Jenkins --- M be/src/kudu/rpc/protoc-gen-krpc.cc M be/src/kudu/rpc/request_tracker-test.cc M be/src/kudu/rpc/request_tracker.cc M be/src/kudu/rpc/request_tracker.h M be/src/kudu/rpc/retriable_rpc.h M be/src/kudu/security/ca/cert_management.cc M be/src/kudu/security/cert.cc M be/src/kudu/security/crypto.cc M be/src/kudu/security/openssl_util.h M be/src/kudu/security/openssl_util_bio.h M be/src/kudu/security/tls_context.cc M be/src/kudu/util/debug/trace_event_impl.cc M be/src/kudu/util/maintenance_manager.cc M be/src/kudu/util/maintenance_manager.h M be/src/kudu/util/mem_tracker-test.cc M be/src/kudu/util/os-util.cc M be/src/kudu/util/process_memory.cc M be/src/kudu/util/rle-test.cc 18 files changed, 85 insertions(+), 85 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/40/7740/1 -- To view, visit http://gerrit.cloudera.org:8080/7740 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7971659ef3152580d44d6ddfb18be7ebf41052c7 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins