Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 5DDE420049B for ; Mon, 14 Aug 2017 21:59:14 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 5C40C165C0B; Mon, 14 Aug 2017 19:59:14 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A0D8B165C06 for ; Mon, 14 Aug 2017 21:59:13 +0200 (CEST) Received: (qmail 87511 invoked by uid 500); 14 Aug 2017 19:59:12 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 87500 invoked by uid 99); 14 Aug 2017 19:59:12 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 14 Aug 2017 19:59:12 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id CA406C0118 for ; Mon, 14 Aug 2017 19:59:11 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 6_fkGH-VcsaR for ; Mon, 14 Aug 2017 19:59:11 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 5B4975F24E for ; Mon, 14 Aug 2017 19:59:10 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v7EJx8G6024459; Mon, 14 Aug 2017 19:59:08 GMT Date: Mon, 14 Aug 2017 19:59:08 +0000 From: "Thomas Tauber-Marshall (Code Review)" To: Marcel Kornacker , impala-cr@cloudera.com, reviews@impala.incubator.apache.org Message-ID: Reply-To: tmarshall@cloudera.com X-Gerrit-MessageType: newchange Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5787=3A_Dropped_status_in_KuduTableSink=3A=3ASend=28=29=0A?= X-Gerrit-Change-Id: Ia228d98ca90de8638b0afcc242c788e225fb450f X-Gerrit-ChangeURL: X-Gerrit-Commit: 777e499b86c2bd57bb0de350be30a1443e34ec36 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Mon, 14 Aug 2017 19:59:14 -0000 Thomas Tauber-Marshall has uploaded a new change for review. http://gerrit.cloudera.org:8080/7667 Change subject: IMPALA-5787: Dropped status in KuduTableSink::Send() ...................................................................... IMPALA-5787: Dropped status in KuduTableSink::Send() KuduTableSink drops the Status returned from WriteKuduValue(), potentially hiding failures. There are only two possible ways WriteKuduValue() can fail: one of the KuduPartialRow::Set functions fails, which can only happen if the specified type is incorrect, which would be a bug in planning and is therefore DCHECK-able, or if TimestampValue::UtcToUnixTimeMicros() fails, which WriteKuduValue() DCHECKs against but also has a path to return the error in release builds. So similarly, this patch adds a DCHECK that the status is OK, and a path to return the error in release builds. It also adds WARN_UNUSED_RESULT to WriteKuduValue() to prevent similar bugs in the future. Testing: - Ran the Kudu tests. Change-Id: Ia228d98ca90de8638b0afcc242c788e225fb450f --- M be/src/exec/kudu-table-sink.cc M be/src/exec/kudu-util.h 2 files changed, 8 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/67/7667/1 -- To view, visit http://gerrit.cloudera.org:8080/7667 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia228d98ca90de8638b0afcc242c788e225fb450f Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall