Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 06C2F1688B3 for ; Wed, 9 Aug 2017 07:46:08 +0200 (CEST) Received: (qmail 98332 invoked by uid 500); 9 Aug 2017 05:46:08 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 98320 invoked by uid 99); 9 Aug 2017 05:46:07 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 Aug 2017 05:46:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 338FAC3E04 for ; Wed, 9 Aug 2017 05:46:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id AiMPpvN2PLnm for ; Wed, 9 Aug 2017 05:46:05 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id BC8605F3D1 for ; Wed, 9 Aug 2017 05:46:04 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v795k3E5014788; Wed, 9 Aug 2017 05:46:03 GMT Date: Wed, 9 Aug 2017 05:46:03 +0000 From: "Henry Robinson (Code Review)" To: Marcel Kornacker , impala-cr@cloudera.com, reviews@impala.incubator.apache.org Message-ID: Reply-To: henry@cloudera.com X-Gerrit-MessageType: newchange Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5781=3A_Only_use_TLSv1=2E0-compatible_ciphers_for_tests=0A?= X-Gerrit-Change-Id: Id66508040bcc7745b7c68b62ace71ae1d394c1b4 X-Gerrit-ChangeURL: X-Gerrit-Commit: cb91eeeea696d02fcadc45c5acaad23b185c4e2a MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/7624 Change subject: IMPALA-5781: Only use TLSv1.0-compatible ciphers for tests ...................................................................... IMPALA-5781: Only use TLSv1.0-compatible ciphers for tests If we ask OpenSSL to use a cipher suite that's not compatible with TLSv1.0, it will fail on machines where TLSv1.1+ is not supported (i.e. those with OpenSSL v1.0.0). Fix tests to only use TLSv1.0-compatible cipher suites, picked from https://wiki.openssl.org/index.php/Manual:Ciphers(1)#TLS_v1.0_cipher_suites. Confirmed that tests start servers with TLSv1.0 support. Before this patch, servers would be silently upgraded to TLSv1.2 only (i.e. the minimum version that supported the requested cipher suite). Change-Id: Id66508040bcc7745b7c68b62ace71ae1d394c1b4 --- M be/src/rpc/thrift-server-test.cc 1 file changed, 15 insertions(+), 7 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/24/7624/1 -- To view, visit http://gerrit.cloudera.org:8080/7624 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id66508040bcc7745b7c68b62ace71ae1d394c1b4 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson