Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 0644C2004F1 for ; Wed, 30 Aug 2017 11:17:53 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 0419716736D; Wed, 30 Aug 2017 09:17:53 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 4B42A167369 for ; Wed, 30 Aug 2017 11:17:52 +0200 (CEST) Received: (qmail 99055 invoked by uid 500); 30 Aug 2017 09:17:51 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 99044 invoked by uid 99); 30 Aug 2017 09:17:51 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 30 Aug 2017 09:17:51 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id C5B01C2EF7 for ; Wed, 30 Aug 2017 09:17:50 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 5M0clrrW4IuN for ; Wed, 30 Aug 2017 09:17:50 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 79FAA60E11 for ; Wed, 30 Aug 2017 09:17:49 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v7U9Hlcc009457; Wed, 30 Aug 2017 09:17:47 GMT Message-Id: <201708300917.v7U9Hlcc009457@ip-10-146-233-104.ec2.internal> Date: Wed, 30 Aug 2017 09:17:47 +0000 From: "Dimitris Tsirogiannis (Code Review)" To: Alex Behm , impala-cr@cloudera.com, reviews@impala.incubator.apache.org Reply-To: dtsirogiannis@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5850=3A_Cast_sender_partition_exprs_under_unions=2E=0A?= X-Gerrit-Change-Id: I0aa801bcad8c2324d848349c7967d949224404e0 X-Gerrit-ChangeURL: X-Gerrit-Commit: 77619bc2c3444b2c87e4adfd757eabf7d6d6b621 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Wed, 30 Aug 2017 09:17:53 -0000 Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5850: Cast sender partition exprs under unions. ...................................................................... Patch Set 1: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/7884/1/fe/src/main/java/org/apache/impala/planner/PlanFragment.java File fe/src/main/java/org/apache/impala/planner/PlanFragment.java: PS1, Line 184: In particular, partitioned hash joins under a union are : * treated as different series of joins (could have different data partitions). Can you expand the comment to explain what 'node' represents? Also, that part of the comment doesn't really help understanding this function and is similar to the comment in L178. Maybe remove? http://gerrit.cloudera.org:8080/#/c/7884/1/testdata/workloads/functional-query/queries/QueryTest/joins.test File testdata/workloads/functional-query/queries/QueryTest/joins.test: PS1, Line 761: nit: extra space -- To view, visit http://gerrit.cloudera.org:8080/7884 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0aa801bcad8c2324d848349c7967d949224404e0 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-HasComments: Yes