Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 978D0200CF3 for ; Wed, 30 Aug 2017 01:43:19 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 96356167DE0; Tue, 29 Aug 2017 23:43:19 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id DD744167DDF for ; Wed, 30 Aug 2017 01:43:18 +0200 (CEST) Received: (qmail 8992 invoked by uid 500); 29 Aug 2017 23:43:16 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 8981 invoked by uid 99); 29 Aug 2017 23:43:15 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 29 Aug 2017 23:43:15 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 6F747C2F8F for ; Tue, 29 Aug 2017 23:43:15 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id U1pUekvYUMKS for ; Tue, 29 Aug 2017 23:43:14 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id F334C5FCBA for ; Tue, 29 Aug 2017 23:43:13 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v7TNhCFW032055; Tue, 29 Aug 2017 23:43:12 GMT Message-Id: <201708292343.v7TNhCFW032055@ip-10-146-233-104.ec2.internal> Date: Tue, 29 Aug 2017 23:43:12 +0000 From: "Tim Armstrong (Code Review)" To: Joe McDonnell , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Sailesh Mukil Reply-To: tarmstrong@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5750=3A_Catch_exceptions_from_boost_thread_creation=0A?= X-Gerrit-Change-Id: I15a2f278dc71892b7fec09593f81b1a57ab725c0 X-Gerrit-ChangeURL: X-Gerrit-Commit: 490d1ff55cb6d3aaf7a572bd6a0882f0f080ea3b In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Tue, 29 Aug 2017 23:43:19 -0000 Tim Armstrong has posted comments on this change. Change subject: IMPALA-5750: Catch exceptions from boost thread creation ...................................................................... Patch Set 5: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/7730/5/be/src/util/thread.cc File be/src/util/thread.cc: Line 48: DEFINE_bool(thread_creation_fault_injection, false, "Causes calls to Thread::Create() " Nice! It seems like this should probably be grouped with other stress options in common/global-flags.cc. Those are also only enabled for debug builds. I guess it could be interesting to test on release builds since the timing will be different but ensure if it's worth making this a special case. -- To view, visit http://gerrit.cloudera.org:8080/7730 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I15a2f278dc71892b7fec09593f81b1a57ab725c0 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Sailesh Mukil Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes