Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 697B3200498 for ; Tue, 29 Aug 2017 19:44:48 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 67B64167323; Tue, 29 Aug 2017 17:44:48 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id AE932167321 for ; Tue, 29 Aug 2017 19:44:47 +0200 (CEST) Received: (qmail 65031 invoked by uid 500); 29 Aug 2017 17:44:46 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 65020 invoked by uid 99); 29 Aug 2017 17:44:46 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 29 Aug 2017 17:44:46 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 2D2C3C1E92 for ; Tue, 29 Aug 2017 17:44:46 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id mPQh-yL9RoHc for ; Tue, 29 Aug 2017 17:44:45 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 4D7005FE15 for ; Tue, 29 Aug 2017 17:44:45 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v7THii6a020059; Tue, 29 Aug 2017 17:44:44 GMT Message-Id: <201708291744.v7THii6a020059@ip-10-146-233-104.ec2.internal> Date: Tue, 29 Aug 2017 17:44:44 +0000 From: "Sailesh Mukil (Code Review)" To: Henry Robinson , impala-cr@cloudera.com, reviews@impala.incubator.apache.org Reply-To: sailesh@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5Bnative-toolchain-CR=5D_IMPALA-5849=3A_Disable_compile-time_checks_for_OpenSSL_=3E_1=2E0=2E0=0A?= X-Gerrit-Change-Id: I437703b2221cba6a2c3079c540ccbda571f8db0e X-Gerrit-ChangeURL: X-Gerrit-Commit: 808cbb94eac01d6d7e2041e111fee370beed4248 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Tue, 29 Aug 2017 17:44:48 -0000 Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5849: Disable compile-time checks for OpenSSL > 1.0.0 ...................................................................... Patch Set 4: Code-Review+2 (1 comment) LGTM, just need to add a comment as mentioned below, so it's clear while reading the code. http://gerrit.cloudera.org:8080/#/c/7859/4/source/thrift/thrift-0.9.0-patches/0011-CLD-Patch-11-IMPALA-5849-Don-t-use-compile-time-chec.patch File source/thrift/thrift-0.9.0-patches/0011-CLD-Patch-11-IMPALA-5849-Don-t-use-compile-time-chec.patch: PS4, Line 35: SSL_OP_NO_TLSv1_2 0x08000000L > SSL_CTX_set_options returns the options that are set after that call takes Thanks for the explanation. I think it would be good to add a comment to that effect at L81. -- To view, visit http://gerrit.cloudera.org:8080/7859 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I437703b2221cba6a2c3079c540ccbda571f8db0e Gerrit-PatchSet: 4 Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Sailesh Mukil Gerrit-HasComments: Yes