Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id EB7E6200D10 for ; Sat, 26 Aug 2017 03:14:51 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id E9ED916D9B0; Sat, 26 Aug 2017 01:14:51 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 3DBBC16D9AF for ; Sat, 26 Aug 2017 03:14:51 +0200 (CEST) Received: (qmail 40945 invoked by uid 500); 26 Aug 2017 01:14:50 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 40930 invoked by uid 99); 26 Aug 2017 01:14:50 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 26 Aug 2017 01:14:50 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 334871A241F for ; Sat, 26 Aug 2017 01:14:49 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id s2xB9DtUQlNR for ; Sat, 26 Aug 2017 01:14:48 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id B88835FE64 for ; Sat, 26 Aug 2017 01:14:47 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v7Q1Ej0h031941; Sat, 26 Aug 2017 01:14:45 GMT Message-Id: <201708260114.v7Q1Ej0h031941@ip-10-146-233-104.ec2.internal> Date: Sat, 26 Aug 2017 01:14:45 +0000 From: "John Sherman (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Sailesh Mukil , Henry Robinson , Matthew Jacobs , Dan Hecht Reply-To: jfs@arcadiadata.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5394=3A_Change_ThriftServer=28=29_to_always_use_TAcceptQueueServer=0A?= X-Gerrit-Change-Id: I56a5f3d9cf931cff14eae7f236fea018236a6255 X-Gerrit-ChangeURL: X-Gerrit-Commit: 534c2f3d744318591fca410d68d2657633ec4c5b In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Sat, 26 Aug 2017 01:14:52 -0000 John Sherman has posted comments on this change. Change subject: IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer ...................................................................... Patch Set 8: (1 comment) Thanks for the feedback Henry. I've attempted to create an effective test. http://gerrit.cloudera.org:8080/#/c/7061/8/be/src/rpc/thrift-server-test.cc File be/src/rpc/thrift-server-test.cc: Line 439: EXPECT_TRUE(did_reach_max); Not sure if this will be effective. Could end up being racy? If so probably extremely rare? -- To view, visit http://gerrit.cloudera.org:8080/7061 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56a5f3d9cf931cff14eae7f236fea018236a6255 Gerrit-PatchSet: 8 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Sherman Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: John Sherman Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Sailesh Mukil Gerrit-HasComments: Yes