Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Message-Id: <201708252306.v7PN6mQd024639@ip-10-146-233-104.ec2.internal>
Date: Fri, 25 Aug 2017 23:06:47 +0000
From: "Matthew Jacobs (Code Review)" <gerrit@cloudera.org>
To: Philip Zeyliger <philip@cloudera.com>, impala-cr@cloudera.com,
        reviews@impala.incubator.apache.org
CC: Dan Hecht <dhecht@cloudera.com>, Tim Armstrong <tarmstrong@cloudera.com>
Reply-To: mj@cloudera.com
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5838=3A_Improve_errors_on_AC_buffer_mem_rejection=0A?=
In-Reply-To: <gerrit.1503694196000.I3dc3517195508d86078a8a4b537ae7d2f52fbcb7@gerrit.cloudera.org>
References: <gerrit.1503694196000.I3dc3517195508d86078a8a4b537ae7d2f52fbcb7@gerrit.cloudera.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.12.7
archived-at: Fri, 25 Aug 2017 23:06:54 -0000

Hello Philip Zeyliger,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/7834

to look at the new patch set (#4).

Change subject: IMPALA-5838: Improve errors on AC buffer mem rejection
......................................................................

IMPALA-5838: Improve errors on AC buffer mem rejection

The error message returned when a query is rejected due to
insufficient buffer memory is misleading. It recommended a
mem_limit which would be high enough, but changing the
mem_limit may result in changing the plan, which may result
in further changes to the buffer memory requirement.

In particular, this can happen when the planner compares the
expected hash table size to the mem_limit, and decides to
choose a partitioned join over a broadcast join.

While we might consider other code changes to improve this,
for now lets just be clear in the error message.

Testing:
* Adds tests that verify the expected behavior with the new
  error message.

Change-Id: I3dc3517195508d86078a8a4b537ae7d2f52fbcb7
---
M be/src/scheduling/admission-controller.cc
A testdata/workloads/functional-query/queries/QueryTest/admission-reject-min-reservation.test
M tests/custom_cluster/test_admission_controller.py
3 files changed, 57 insertions(+), 28 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/34/7834/4
-- 
To view, visit http://gerrit.cloudera.org:8080/7834
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3dc3517195508d86078a8a4b537ae7d2f52fbcb7
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <philip@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>