Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id F19E2200D0D for ; Fri, 25 Aug 2017 23:01:57 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id F013516D3F3; Fri, 25 Aug 2017 21:01:57 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 437E316D3F0 for ; Fri, 25 Aug 2017 23:01:57 +0200 (CEST) Received: (qmail 94475 invoked by uid 500); 25 Aug 2017 21:01:56 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 94463 invoked by uid 99); 25 Aug 2017 21:01:56 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 25 Aug 2017 21:01:56 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id B50ED1A1B3C for ; Fri, 25 Aug 2017 21:01:55 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id QmWbmWW_brPB for ; Fri, 25 Aug 2017 21:01:53 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 16E205F6D3 for ; Fri, 25 Aug 2017 21:01:53 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v7PL1prT017845; Fri, 25 Aug 2017 21:01:51 GMT Message-Id: <201708252101.v7PL1prT017845@ip-10-146-233-104.ec2.internal> Date: Fri, 25 Aug 2017 21:01:51 +0000 From: "Philip Zeyliger (Code Review)" To: Matthew Jacobs , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Dan Hecht , Tim Armstrong Reply-To: philip@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5838=3A_Improve_errors_on_AC_buffer_mem_rejection=0A?= X-Gerrit-Change-Id: I3dc3517195508d86078a8a4b537ae7d2f52fbcb7 X-Gerrit-ChangeURL: X-Gerrit-Commit: 53610ed1939754e718ebf94c1c23613d31c6ec26 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Fri, 25 Aug 2017 21:01:58 -0000 Philip Zeyliger has posted comments on this change. Change subject: IMPALA-5838: Improve errors on AC buffer mem rejection ...................................................................... Patch Set 1: (1 comment) Looks like there are some stray comments? http://gerrit.cloudera.org:8080/#/c/7834/1/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: Line 334: #vector.get_value('exec_option')['num_nodes'] = 1 What's up here? -- To view, visit http://gerrit.cloudera.org:8080/7834 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3dc3517195508d86078a8a4b537ae7d2f52fbcb7 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes