Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B30E0200CFE for ; Fri, 25 Aug 2017 00:11:56 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id B177216BC02; Thu, 24 Aug 2017 22:11:56 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 062A216BC01 for ; Fri, 25 Aug 2017 00:11:55 +0200 (CEST) Received: (qmail 53669 invoked by uid 500); 24 Aug 2017 22:11:54 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 53623 invoked by uid 99); 24 Aug 2017 22:11:53 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 24 Aug 2017 22:11:53 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 7EB38180353 for ; Thu, 24 Aug 2017 22:11:53 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id ZtT9_LrK5jxk for ; Thu, 24 Aug 2017 22:11:52 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id B070461B3C for ; Thu, 24 Aug 2017 22:11:51 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v7OMBnqT023265; Thu, 24 Aug 2017 22:11:50 GMT Message-Id: <201708242211.v7OMBnqT023265@ip-10-146-233-104.ec2.internal> Date: Thu, 24 Aug 2017 22:11:49 +0000 From: "Tim Armstrong (Code Review)" To: Philip Zeyliger , impala-cr@cloudera.com, reviews@impala.incubator.apache.org Reply-To: tarmstrong@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-3642=3A_Adding_backend_addresses_to_error_statuses_for_scratch_failures=2E=0A?= X-Gerrit-Change-Id: If31a50fdf6031312d0348d48aeb8f9688274cac2 X-Gerrit-ChangeURL: X-Gerrit-Commit: 40bb6330e91a092fcac5ba56f0525f50c927969e In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Thu, 24 Aug 2017 22:11:56 -0000 Tim Armstrong has posted comments on this change. Change subject: IMPALA-3642: Adding backend addresses to error statuses for scratch failures. ...................................................................... Patch Set 1: We have test coverage for scratch errors in a few places: be/src/runtime/bufferpool/buffer-pool-test.cc be/src/runtime/tmp-file-mgr-test.cc tests/custom_cluster/test_scratch_disk.py There are a bunch of write error tests and a single read error test: BufferPoolTest::ScratchReadError The backend unit tests check the error codes but not the error messages - one option is to extend them to check the error messages. I haven't fully thought through how it would work out, but it might be easier to add this information to the error message in be/src/tmp-file-mgr.cc. The write errors get rolled up into a SCRATCH_ALLOCATION_FAILED message (there may be more than one per disk). There are also a couple of other error types that emanate from that file: SCRATCH_LIMIT_EXCEEDED and SCRATCH_READ_TRUNCATED. -- To view, visit http://gerrit.cloudera.org:8080/7816 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If31a50fdf6031312d0348d48aeb8f9688274cac2 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Philip Zeyliger Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No