Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 3EAA52004A1 for ; Thu, 24 Aug 2017 18:51:54 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 3CF4A16B27C; Thu, 24 Aug 2017 16:51:54 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 8329016B277 for ; Thu, 24 Aug 2017 18:51:53 +0200 (CEST) Received: (qmail 22605 invoked by uid 500); 24 Aug 2017 16:51:52 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 22594 invoked by uid 99); 24 Aug 2017 16:51:52 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 24 Aug 2017 16:51:51 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 8B455C0334 for ; Thu, 24 Aug 2017 16:51:51 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 9f9RRyNlSTf2 for ; Thu, 24 Aug 2017 16:51:50 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 1A8E45FB2F for ; Thu, 24 Aug 2017 16:51:50 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v7OGpmnI008616; Thu, 24 Aug 2017 16:51:48 GMT Message-Id: <201708241651.v7OGpmnI008616@ip-10-146-233-104.ec2.internal> Date: Thu, 24 Aug 2017 16:51:48 +0000 From: "Dan Hecht (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org Reply-To: dhecht@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5108=3A_Followup_change_to_do_the_cleanup=2E=0A?= X-Gerrit-Change-Id: I521e7e493e4ae26e1955861637cd31f5f678dd0b X-Gerrit-ChangeURL: X-Gerrit-Commit: bc64624ebd9834a4e6ea161d18567ece0f814318 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Thu, 24 Aug 2017 16:51:54 -0000 Dan Hecht has posted comments on this change. Change subject: IMPALA-5108: Followup change to do the cleanup. ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/7801/1/be/src/service/session-expiry-test.cc File be/src/service/session-expiry-test.cc: PS1, Line 83: ( nit: extraneous parenthesis PS1, Line 89: (MAX_IDLE_TIMEOUT_MS/1000) nit: extraneous parenthesis and should have space around / -- To view, visit http://gerrit.cloudera.org:8080/7801 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I521e7e493e4ae26e1955861637cd31f5f678dd0b Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Dan Hecht Gerrit-HasComments: Yes