Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D7BCD200CFC for ; Thu, 24 Aug 2017 03:06:24 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id D5C1C16A160; Thu, 24 Aug 2017 01:06:24 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 294E116A161 for ; Thu, 24 Aug 2017 03:06:24 +0200 (CEST) Received: (qmail 87333 invoked by uid 500); 24 Aug 2017 01:06:23 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 87322 invoked by uid 99); 24 Aug 2017 01:06:23 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 24 Aug 2017 01:06:23 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id A44581A217B for ; Thu, 24 Aug 2017 01:06:22 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id OxPFBzZAUitf for ; Thu, 24 Aug 2017 01:06:21 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 8CEA65FBE2 for ; Thu, 24 Aug 2017 01:06:21 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v7O16JcM016469; Thu, 24 Aug 2017 01:06:19 GMT Message-Id: <201708240106.v7O16JcM016469@ip-10-146-233-104.ec2.internal> Date: Thu, 24 Aug 2017 01:06:19 +0000 From: "Matthew Mulder (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Michael Brown , David Knupp , Tim Wood Reply-To: mmulder@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5625=3A_stress_test=3A_write_profile_when_queries_fail=0A?= X-Gerrit-Change-Id: I1dbdf5fcf97d6c5681c9fc8fb9eb448bc459b3b0 X-Gerrit-ChangeURL: X-Gerrit-Commit: 18c192fdc697be2f10ec777bb29460071524e59e In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Thu, 24 Aug 2017 01:06:25 -0000 Matthew Mulder has posted comments on this change. Change subject: IMPALA-5625: stress test: write profile when queries fail ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7376/2/tests/stress/concurrent_select.py File tests/stress/concurrent_select.py: PS2, Line 1668: get_profile > The first word in the docstring is "set". :) fetch_profile() is OK, but the How about fetch_and_set_profile()? -- To view, visit http://gerrit.cloudera.org:8080/7376 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1dbdf5fcf97d6c5681c9fc8fb9eb448bc459b3b0 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Mulder Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Matthew Mulder Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Tim Wood Gerrit-HasComments: Yes