Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Message-Id: <201708232046.v7NKkTIv027091@ip-10-146-233-104.ec2.internal>
Date: Wed, 23 Aug 2017 20:46:29 +0000
From: "Henry Robinson (Code Review)" <gerrit@cloudera.org>
To: Philip Zeyliger <philip@cloudera.com>, impala-cr@cloudera.com,
        reviews@impala.incubator.apache.org
CC: Dan Hecht <dhecht@cloudera.com>, Matthew Jacobs <mj@cloudera.com>
Reply-To: henry@cloudera.com
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5211=3A_Simplifying_ifnull/isnull/nvl_where_conditional_is_a_literal=2E=0A?=
In-Reply-To: <gerrit.1503505030000.I9e4b8bf6fedd595f9ea54ffb30fc71a058c7f16c@gerrit.cloudera.org>
References: <gerrit.1503505030000.I9e4b8bf6fedd595f9ea54ffb30fc71a058c7f16c@gerrit.cloudera.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.12.7
archived-at: Wed, 23 Aug 2017 20:46:33 -0000

Henry Robinson has posted comments on this change.

Change subject: IMPALA-5211: Simplifying ifnull/isnull/nvl where conditional is a literal.
......................................................................


Patch Set 3:

(4 comments)

just passing through.

http://gerrit.cloudera.org:8080/#/c/7781/3//COMMIT_MSG
Commit Message:

PS3, Line 12: I did the naive thing for recognizing that ifnull has variants.
nit: not clear what this means (becomes clear upon reading the patch). Might be more helpful to say that you hardcoded the set of ifnull aliases.


http://gerrit.cloudera.org:8080/#/c/7781/3/fe/src/main/java/org/apache/impala/rewrite/SimplifyConditionalsRule.java
File fe/src/main/java/org/apache/impala/rewrite/SimplifyConditionalsRule.java:

Line 55:   private static List<String> IFNULL_ALIASES = ImmutableList.of("ifnull", "isnull", "nvl");
nit: long line (by one character)


Line 107:   private Expr simplifyIfNullFunctionCallExpr(FunctionCallExpr expr) {
static?


PS3, Line 148: ifnull
update comment


-- 
To view, visit http://gerrit.cloudera.org:8080/7781
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e4b8bf6fedd595f9ea54ffb30fc71a058c7f16c
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Philip Zeyliger <philip@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <philip@cloudera.com>
Gerrit-HasComments: Yes