Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 8BD96200D08 for ; Wed, 23 Aug 2017 02:33:54 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 8A3E0167E8D; Wed, 23 Aug 2017 00:33:54 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D8106167E8A for ; Wed, 23 Aug 2017 02:33:53 +0200 (CEST) Received: (qmail 85218 invoked by uid 500); 23 Aug 2017 00:33:53 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 85207 invoked by uid 99); 23 Aug 2017 00:33:52 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 23 Aug 2017 00:33:52 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 792B1C0169 for ; Wed, 23 Aug 2017 00:33:52 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id MZBZu6eefP4b for ; Wed, 23 Aug 2017 00:33:51 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 16CD25F659 for ; Wed, 23 Aug 2017 00:33:50 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v7N0Xn77030207; Wed, 23 Aug 2017 00:33:49 GMT Message-Id: <201708230033.v7N0Xn77030207@ip-10-146-233-104.ec2.internal> Date: Wed, 23 Aug 2017 00:33:49 +0000 From: "Dan Hecht (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org Reply-To: dhecht@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5108=3A_idle_session_timeout_kicks_in_later_than_expected=0A?= X-Gerrit-Change-Id: I827a5fa2246e7b05b718fb8b4563b8488c91a1d9 X-Gerrit-ChangeURL: X-Gerrit-Commit: 2b0f56f9a43141249fc61dfe71b4ff5697148284 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Wed, 23 Aug 2017 00:33:54 -0000 Dan Hecht has posted comments on this change. Change subject: IMPALA-5108: idle_session_timeout kicks in later than expected ...................................................................... Patch Set 1: (8 comments) Great to see this one get fixed. http://gerrit.cloudera.org:8080/#/c/7729/1//COMMIT_MSG Commit Message: PS1, Line 17: reduce what's the reason to reduce this time? Line 18: of max_idle_timeout_ms let's generally keep the messages left justified (exception inside formatted structures e.g. bulleted lists). http://gerrit.cloudera.org:8080/#/c/7729/1/be/src/service/session-expiry-test.cc File be/src/service/session-expiry-test.cc: PS1, Line 68: gets one session eac since we're really trying to create multiple sessions (and just using clients to do that) maybe NUM_CLIENTS should be called NUM_SESSIONS? PS1, Line 83: 10 that looks like it should be expressed in terms of NUM_CLIENTS. PS1, Line 87: 5s 5s should be updated if you're changing that value. PS1, Line 87: 10L same PS1, Line 88: 5L isn't that NUM_CLIENTS? PS1, Line 90: 5L same -- To view, visit http://gerrit.cloudera.org:8080/7729 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I827a5fa2246e7b05b718fb8b4563b8488c91a1d9 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Dan Hecht Gerrit-HasComments: Yes