Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Message-Id: <201708222339.v7MNdERb026802@ip-10-146-233-104.ec2.internal>
Date: Tue, 22 Aug 2017 23:39:14 +0000
From: "Dimitris Tsirogiannis (Code Review)" <gerrit@cloudera.org>
To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org
CC: Alex Behm <alex.behm@cloudera.com>
Reply-To: dtsirogiannis@cloudera.com
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5531=3A_Fix_correctness_issue_in_correlated_aggregate_subqueries=0A?=
In-Reply-To: <gerrit.1502996927000.I6ca7b60ef0543430d2f5a802285254ebb52db2ab@gerrit.cloudera.org>
References: <gerrit.1502996927000.I6ca7b60ef0543430d2f5a802285254ebb52db2ab@gerrit.cloudera.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.12.7
archived-at: Tue, 22 Aug 2017 23:39:19 -0000

Dimitris Tsirogiannis has posted comments on this change.

Change subject: IMPALA-5531: Fix correctness issue in correlated aggregate subqueries
......................................................................


Patch Set 3:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/7706/3/fe/src/main/java/org/apache/impala/analysis/Expr.java
File fe/src/main/java/org/apache/impala/analysis/Expr.java:

Line 1417:   public static String toSqlHelper(List<Expr> exprs) {
> listToSql()?
Done


http://gerrit.cloudera.org:8080/#/c/7706/3/fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java
File fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java:

Line 399:     // Ensure that all the extracted correlated predicates can be added to the on-clause
> nit: we usually use caps for clauses and such, i.e. ON-clause
Done


Line 648:   private static void canRewriteCorrelatedSubquery(Expr expr) throws AnalysisException {
> validateCorrelatedSubqueryStmt()?
Done


Line 676:    * added to the on-clause of the join that results from the subquert rewrite; It throws
> ON-clause and typo: subquery. Also use "." instead of ";"
Done


Line 683:     Preconditions.checkNotNull(correlatedPredicates);
> Preconditions.checkState(inlineView.isAnalyzed());
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7706
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6ca7b60ef0543430d2f5a802285254ebb52db2ab
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-HasComments: Yes