Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id F09EB200D08 for ; Wed, 23 Aug 2017 01:04:43 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id EEFCE167CAB; Tue, 22 Aug 2017 23:04:43 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 41870167CAA for ; Wed, 23 Aug 2017 01:04:43 +0200 (CEST) Received: (qmail 4953 invoked by uid 500); 22 Aug 2017 23:04:41 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 4942 invoked by uid 99); 22 Aug 2017 23:04:41 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Aug 2017 23:04:41 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id BDA52180360 for ; Tue, 22 Aug 2017 23:04:40 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id sfMDVaypu37r for ; Tue, 22 Aug 2017 23:04:40 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id CB1525FAF3 for ; Tue, 22 Aug 2017 23:04:39 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v7MN4cCv023428; Tue, 22 Aug 2017 23:04:38 GMT Message-Id: <201708222304.v7MN4cCv023428@ip-10-146-233-104.ec2.internal> Date: Tue, 22 Aug 2017 23:04:38 +0000 From: "Tim Armstrong (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Dan Hecht Reply-To: tarmstrong@cloudera.com X-Gerrit-MessageType: newpatchset Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5823=3A_fix_SET_DENY_RESERVATION_PROBABILITY=0A?= X-Gerrit-Change-Id: Ib26b697544d6c2312a8e1fe91b0cf8c0917e5603 X-Gerrit-ChangeURL: X-Gerrit-Commit: 1e55ffd900da23e6d27ab3c486ae20be897399ca In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Tue, 22 Aug 2017 23:04:44 -0000 Tim Armstrong has uploaded a new patch set (#3). Change subject: IMPALA-5823: fix SET_DENY_RESERVATION_PROBABILITY ...................................................................... IMPALA-5823: fix SET_DENY_RESERVATION_PROBABILITY Always set the probability even if the client is not yet open. This always worked but added comments explicitly mentioning that it should work. This caused one of the large row tests to start failing with a "failed to repartition" error in the aggregation. The error is a false positive caused by two distinct keys hashing to the same partition. Removing the check allows the query to succeed because the keys hash to different partitions in the next round of repartitioning. Testing: Ran TestSpilling in a loop for a couple of hours, including the exhaustive-only tests. Change-Id: Ib26b697544d6c2312a8e1fe91b0cf8c0917e5603 --- M be/src/exec/exec-node.cc M be/src/exec/exec-node.h M be/src/exec/partitioned-aggregation-node.cc M be/src/exec/partitioned-aggregation-node.h M common/thrift/generate_error_codes.py 5 files changed, 33 insertions(+), 44 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/71/7771/3 -- To view, visit http://gerrit.cloudera.org:8080/7771 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib26b697544d6c2312a8e1fe91b0cf8c0917e5603 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Dan Hecht