Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 78BC416736E for ; Tue, 22 Aug 2017 18:18:33 +0200 (CEST) Received: (qmail 10944 invoked by uid 500); 22 Aug 2017 16:18:32 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 10933 invoked by uid 99); 22 Aug 2017 16:18:32 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Aug 2017 16:18:32 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id CDAB41A044F for ; Tue, 22 Aug 2017 16:18:31 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id sbxC5njpz3S5 for ; Tue, 22 Aug 2017 16:18:31 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 79B585FAF7 for ; Tue, 22 Aug 2017 16:18:30 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v7MGISrl002732; Tue, 22 Aug 2017 16:18:28 GMT Message-Id: <201708221618.v7MGISrl002732@ip-10-146-233-104.ec2.internal> Date: Tue, 22 Aug 2017 16:18:28 +0000 From: "Matthew Jacobs (Code Review)" To: Thomas Tauber-Marshall , impala-cr@cloudera.com, reviews@impala.incubator.apache.org Reply-To: mj@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5799=3A_Kudu_DML_can_crash_if_schema_has_changed=0A?= X-Gerrit-Change-Id: I9fd6bf164310df0041144f75f5ee722665e9f587 X-Gerrit-ChangeURL: X-Gerrit-Commit: 7a07c58ed64a098ee7875d3a739e425ab2786931 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5799: Kudu DML can crash if schema has changed ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7688/3/be/src/exec/kudu-table-sink.cc File be/src/exec/kudu-table-sink.cc: PS3, Line 147: <= > Suppose you have a table with '3' columns. The highest col_idx that would b Yes you're right, I misread it. I think it'll be more obvious if you flip the inequality. -- To view, visit http://gerrit.cloudera.org:8080/7688 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9fd6bf164310df0041144f75f5ee722665e9f587 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-HasComments: Yes