Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E60F116294B for ; Tue, 22 Aug 2017 02:59:18 +0200 (CEST) Received: (qmail 5911 invoked by uid 500); 22 Aug 2017 00:59:18 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 5896 invoked by uid 99); 22 Aug 2017 00:59:17 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Aug 2017 00:59:17 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 761DC1A1CAC for ; Tue, 22 Aug 2017 00:59:17 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 2gc0tK4cQqSj for ; Tue, 22 Aug 2017 00:59:16 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id A178C5FDBC for ; Tue, 22 Aug 2017 00:59:16 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v7M0xGF0017612; Tue, 22 Aug 2017 00:59:16 GMT Message-Id: <201708220059.v7M0xGF0017612@ip-10-146-233-104.ec2.internal> Date: Tue, 22 Aug 2017 00:59:16 +0000 From: "Dan Hecht (Code Review)" To: Bikramjeet Vig , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Matthew Jacobs Reply-To: dhecht@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5784_=3A_Separate_planner_and_user_set_query_options_in_profile=0A?= X-Gerrit-Change-Id: Ibfc7832963fa0bd278a45c06a5a54e1bf40d8876 X-Gerrit-ChangeURL: X-Gerrit-Commit: f0b1b0480254b32b1718c677fae8644e015d2eef In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 Dan Hecht has posted comments on this change. Change subject: IMPALA-5784 : Separate planner and user set query options in profile ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7721/1/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: Line 151: summary_profile_.AddInfoString("Query Options (non default, after planning)", this is probably okay, but i wonder if it'd be clearer if we instead either: A) just have mutually exclusive lists where the options set by the impala are in one list and options set by the user/session are in the other list. B) have a single list where options set by Impala are marked with an asterisk or something. if that's much complexity, maybe not worth it. also interested to hear what others think about which is easier to read. -- To view, visit http://gerrit.cloudera.org:8080/7721 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibfc7832963fa0bd278a45c06a5a54e1bf40d8876 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Matthew Jacobs Gerrit-HasComments: Yes