Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id E532D200CF0 for ; Tue, 22 Aug 2017 00:03:02 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id E37CB165C21; Mon, 21 Aug 2017 22:03:02 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 3247A165C1A for ; Tue, 22 Aug 2017 00:03:02 +0200 (CEST) Received: (qmail 71838 invoked by uid 500); 21 Aug 2017 22:03:01 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 71822 invoked by uid 99); 21 Aug 2017 22:03:01 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 21 Aug 2017 22:03:01 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id A23F0C2B06 for ; Mon, 21 Aug 2017 22:03:00 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 2Dsw2BF-WQdE for ; Mon, 21 Aug 2017 22:03:00 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 4BF3160E0C for ; Mon, 21 Aug 2017 22:02:59 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v7LM2vuc004547; Mon, 21 Aug 2017 22:02:57 GMT Message-Id: <201708212202.v7LM2vuc004547@ip-10-146-233-104.ec2.internal> Date: Mon, 21 Aug 2017 22:02:57 +0000 From: "Impala Public Jenkins (Code Review)" To: Tim Armstrong , impala-cr@cloudera.com, reviews@impala.incubator.apache.org X-Gerrit-MessageType: merged Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5819=3A_DCHECK_in_HdfsTextScanner=3A=3AClose=28=29=0A?= X-Gerrit-Change-Id: I3d63f0b0c1ac82103a60b68b244156b9fbd575e0 X-Gerrit-ChangeURL: X-Gerrit-Commit: 7d6b05a7215d579f8df6c0685575662c6cfc09c4 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Mon, 21 Aug 2017 22:03:03 -0000 Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5819: DCHECK in HdfsTextScanner::Close() ...................................................................... IMPALA-5819: DCHECK in HdfsTextScanner::Close() The DCHECK is only valid if the scanner successfully processes the entire scan range. If the scanner is cancelled or hits an error in-between buffers, boundary_column_ may be non-empty. The fix is to move the DCHECK to the end of FinishScanRange(), where it only executes if the scan range is fully processed. Testing: Ran TestCancellation in a loop locally for an hour. Change-Id: I3d63f0b0c1ac82103a60b68b244156b9fbd575e0 Reviewed-on: http://gerrit.cloudera.org:8080/7756 Reviewed-by: Alex Behm Tested-by: Impala Public Jenkins --- M be/src/exec/hdfs-text-scanner.cc 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Impala Public Jenkins: Verified Alex Behm: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/7756 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3d63f0b0c1ac82103a60b68b244156b9fbd575e0 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell