Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id ED1BB200CF2 for ; Fri, 18 Aug 2017 21:50:35 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id EB76A16D65B; Fri, 18 Aug 2017 19:50:35 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 3FC3E16D65D for ; Fri, 18 Aug 2017 21:50:35 +0200 (CEST) Received: (qmail 53322 invoked by uid 500); 18 Aug 2017 19:50:34 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 53311 invoked by uid 99); 18 Aug 2017 19:50:34 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 18 Aug 2017 19:50:34 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id A8C4C1A1C6F for ; Fri, 18 Aug 2017 19:50:33 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id dbcxBKKmIKwt for ; Fri, 18 Aug 2017 19:50:31 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id D7E315FB57 for ; Fri, 18 Aug 2017 19:50:30 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v7IJoUAs008906; Fri, 18 Aug 2017 19:50:30 GMT Message-Id: <201708181950.v7IJoUAs008906@ip-10-146-233-104.ec2.internal> Date: Fri, 18 Aug 2017 19:50:30 +0000 From: "Matthew Jacobs (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Tim Armstrong , Dan Hecht Reply-To: mj@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5644=2CIMPALA-5810=3A_Min_reservation_improvements=0A?= X-Gerrit-Change-Id: Iabe87ce8f460356cfe4d1be4d7092c5900f9d79b X-Gerrit-ChangeURL: X-Gerrit-Commit: b1d150db16165e217b76b7d8c35254504c30e78a In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Fri, 18 Aug 2017 19:50:36 -0000 Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5644,IMPALA-5810: Min reservation improvements ...................................................................... Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/7678/5/be/src/runtime/bufferpool/reservation-util.h File be/src/runtime/bufferpool/reservation-util.h: Line 41: /// (i.e. not accounted by buffer reservation trackers) stays within > This TODO is inconsistent with the others. I dont' think it really matters Done http://gerrit.cloudera.org:8080/#/c/7678/6/be/src/runtime/bufferpool/reservation-util.h File be/src/runtime/bufferpool/reservation-util.h: Line 18: // This file includes constants used for buffer management. > Maybe remove or combine with class comment? Done Line 37: /// determine how much memory will get used for reserved memory vs unreserved memory. > The last part sounds like we're partitioning between the two, but we're rea Ok thanks. I took most of that but modified a bit. PS6, Line 64: hueristic > heuristic Done -- To view, visit http://gerrit.cloudera.org:8080/7678 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iabe87ce8f460356cfe4d1be4d7092c5900f9d79b Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes