Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id E3915200CED for ; Fri, 18 Aug 2017 21:34:45 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id E1EC216D5B8; Fri, 18 Aug 2017 19:34:45 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 346CE16D5B6 for ; Fri, 18 Aug 2017 21:34:45 +0200 (CEST) Received: (qmail 22580 invoked by uid 500); 18 Aug 2017 19:34:42 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 22566 invoked by uid 99); 18 Aug 2017 19:34:42 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 18 Aug 2017 19:34:42 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 32EDA18072A for ; Fri, 18 Aug 2017 19:34:42 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 7-_3xi1wccKY for ; Fri, 18 Aug 2017 19:34:38 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 802C25F523 for ; Fri, 18 Aug 2017 19:34:37 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v7IJYZRN007244; Fri, 18 Aug 2017 19:34:35 GMT Message-Id: <201708181934.v7IJYZRN007244@ip-10-146-233-104.ec2.internal> Date: Fri, 18 Aug 2017 19:34:35 +0000 From: "Impala Public Jenkins (Code Review)" To: Matthew Jacobs , impala-cr@cloudera.com, reviews@impala.incubator.apache.org X-Gerrit-MessageType: merged Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4833=3A_Compute_precise_per-host_reservation_size=2C_pt2=0A?= X-Gerrit-Change-Id: I1391d99ca15d2ebcaabd564fbe1242806be09f72 X-Gerrit-ChangeURL: X-Gerrit-Commit: 985698bb6f69a61bc2bd88b8fb7e89d476d970a5 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Fri, 18 Aug 2017 19:34:46 -0000 Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4833: Compute precise per-host reservation size, pt2 ...................................................................... IMPALA-4833: Compute precise per-host reservation size, pt2 Addresses some comments from the CR: https://gerrit.cloudera.org/#/c/7630/8 Notably changes the name of initial_reservation_total_bytes to initial_reservation_total_claims and attempts to clarify comments. Change-Id: I1391d99ca15d2ebcaabd564fbe1242806be09f72 Reviewed-on: http://gerrit.cloudera.org:8080/7681 Reviewed-by: Dan Hecht Tested-by: Impala Public Jenkins --- M be/src/runtime/coordinator-backend-state.cc M be/src/runtime/query-state.cc M be/src/scheduling/query-schedule.h M be/src/scheduling/scheduler.cc M common/thrift/ImpalaInternalService.thrift M common/thrift/Planner.thrift M fe/src/main/java/org/apache/impala/planner/PlanFragment.java 7 files changed, 39 insertions(+), 27 deletions(-) Approvals: Impala Public Jenkins: Verified Dan Hecht: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/7681 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1391d99ca15d2ebcaabd564fbe1242806be09f72 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Matthew Jacobs