Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B359C200CDF for ; Thu, 17 Aug 2017 22:19:42 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id B1ADC16BB0A; Thu, 17 Aug 2017 20:19:42 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 0465116BB08 for ; Thu, 17 Aug 2017 22:19:41 +0200 (CEST) Received: (qmail 53728 invoked by uid 500); 17 Aug 2017 20:19:41 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 53684 invoked by uid 99); 17 Aug 2017 20:19:40 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Aug 2017 20:19:40 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 8C718C66DB for ; Thu, 17 Aug 2017 20:19:40 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id yP7Sgy7djhx2 for ; Thu, 17 Aug 2017 20:19:39 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 853695F522 for ; Thu, 17 Aug 2017 20:19:39 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v7HKJcoV030756; Thu, 17 Aug 2017 20:19:38 GMT Message-Id: <201708172019.v7HKJcoV030756@ip-10-146-233-104.ec2.internal> Date: Thu, 17 Aug 2017 20:19:38 +0000 From: "Henry Robinson (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Michael Ho Reply-To: henry@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4669=3A_=5BKRPC=5D_Add_kudu_rpc_library_to_build=0A?= X-Gerrit-Change-Id: I33203e95dff07c87a6ec5c7a31b7a583b91849bc X-Gerrit-ChangeURL: X-Gerrit-Commit: 53002b6dae77434ad5cdb2e8ac7ccd1af4748b6f In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Thu, 17 Aug 2017 20:19:42 -0000 Henry Robinson has posted comments on this change. Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build ...................................................................... Patch Set 12: (2 comments) http://gerrit.cloudera.org:8080/#/c/5719/12//COMMIT_MSG Commit Message: PS12, Line 11: One minor linking change to krpc/CMakeLists.txt. > Stale ? Done http://gerrit.cloudera.org:8080/#/c/5719/12/be/CMakeLists.txt File be/CMakeLists.txt: PS12, Line 341: histogram_proto > This is used by kudu/util/metrics.cc, right ? Yes. -- To view, visit http://gerrit.cloudera.org:8080/5719 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I33203e95dff07c87a6ec5c7a31b7a583b91849bc Gerrit-PatchSet: 12 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Michael Ho Gerrit-HasComments: Yes