Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 4625C200CDF for ; Thu, 17 Aug 2017 22:01:33 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 445C416BA5D; Thu, 17 Aug 2017 20:01:33 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 8A8C216BA5C for ; Thu, 17 Aug 2017 22:01:32 +0200 (CEST) Received: (qmail 10595 invoked by uid 500); 17 Aug 2017 20:01:31 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 10583 invoked by uid 99); 17 Aug 2017 20:01:31 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Aug 2017 20:01:31 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 23730C67FC for ; Thu, 17 Aug 2017 20:01:31 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id YF1wMVZEht9n for ; Thu, 17 Aug 2017 20:01:29 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id CD5B75F5B3 for ; Thu, 17 Aug 2017 20:01:28 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v7HK1Rx6029985; Thu, 17 Aug 2017 20:01:27 GMT Message-Id: <201708172001.v7HK1Rx6029985@ip-10-146-233-104.ec2.internal> Date: Thu, 17 Aug 2017 20:01:27 +0000 From: "Impala Public Jenkins (Code Review)" To: Thomas Tauber-Marshall , impala-cr@cloudera.com, reviews@impala.incubator.apache.org X-Gerrit-MessageType: merged Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5796=3A_CTAS_for_Kudu_fails_with_expr_rewrite=0A?= X-Gerrit-Change-Id: Ia67bb33736b5a843663b226cdd0fa5bd839cbea1 X-Gerrit-ChangeURL: X-Gerrit-Commit: 5fcc9cb4cc2a9848c7d8ba677494588d8014fa92 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Thu, 17 Aug 2017 20:01:33 -0000 Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5796: CTAS for Kudu fails with expr rewrite ...................................................................... IMPALA-5796: CTAS for Kudu fails with expr rewrite When an expr rewrite occurs, we reanalyze the statement. Some state that is set in TableDef::analyze() wasn't being reset() first, causing a failure during reanalysis. This patch adds TableDef::reset(), which clears the TableDef state that is set during analyze(). Testing: - Added a regression test in AnalyzeDDLTest Change-Id: Ia67bb33736b5a843663b226cdd0fa5bd839cbea1 Reviewed-on: http://gerrit.cloudera.org:8080/7666 Reviewed-by: Thomas Tauber-Marshall Tested-by: Impala Public Jenkins --- M fe/src/main/java/org/apache/impala/analysis/CreateTableAsSelectStmt.java M fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java M fe/src/main/java/org/apache/impala/analysis/TableDef.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java 4 files changed, 32 insertions(+), 5 deletions(-) Approvals: Impala Public Jenkins: Verified Thomas Tauber-Marshall: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/7666 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia67bb33736b5a843663b226cdd0fa5bd839cbea1 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Thomas Tauber-Marshall