Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 1BF95200CE6 for ; Thu, 17 Aug 2017 03:01:43 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 1A1D5169FA6; Thu, 17 Aug 2017 01:01:43 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 602AC169FA4 for ; Thu, 17 Aug 2017 03:01:42 +0200 (CEST) Received: (qmail 78492 invoked by uid 500); 17 Aug 2017 01:01:41 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 78481 invoked by uid 99); 17 Aug 2017 01:01:39 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Aug 2017 01:01:39 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 22158180582 for ; Thu, 17 Aug 2017 01:01:39 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id K7_UBtDbMxM9 for ; Thu, 17 Aug 2017 01:01:38 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 533F45FB96 for ; Thu, 17 Aug 2017 01:01:38 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v7H11bII011451; Thu, 17 Aug 2017 01:01:37 GMT Message-Id: <201708170101.v7H11bII011451@ip-10-146-233-104.ec2.internal> Date: Thu, 17 Aug 2017 01:01:37 +0000 From: "anujphadke (Code Review)" To: anujphadke , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Tim Armstrong Reply-To: aphadke@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4863/IMPALA-5311=3A_Correctly_account_the_file_type_and_compression_codec=0A?= X-Gerrit-Change-Id: I797916505f62e568f4159e07099481b8ff571da2 X-Gerrit-ChangeURL: X-Gerrit-Commit: b61b4ab972efdf9160b1f94114195591e172b963 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Thu, 17 Aug 2017 01:01:43 -0000 anujphadke has posted comments on this change. Change subject: IMPALA-4863/IMPALA-5311: Correctly account the file type and compression codec ...................................................................... Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/7245/5/be/src/exec/hdfs-scan-node-base.cc File be/src/exec/hdfs-scan-node-base.cc: Line 885: THdfsCompression::type compression_type = std::get<2>(it->first); > nit: missing space before << Done PS5, Line 888: fi > nit: align <<'s vertically (it's in the style guide somewhere). Done http://gerrit.cloudera.org:8080/#/c/7245/5/testdata/workloads/functional-query/queries/QueryTest/hdfs_scanner_profile.test File testdata/workloads/functional-query/queries/QueryTest/hdfs_scanner_profile.test: Line 9: ==== > I missed this in an earlier pass but we don't have a regression test for IM Done -- To view, visit http://gerrit.cloudera.org:8080/7245 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I797916505f62e568f4159e07099481b8ff571da2 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: anujphadke Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: anujphadke Gerrit-HasComments: Yes