Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 4DF78200CE6 for ; Thu, 17 Aug 2017 02:16:39 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 49099169E57; Thu, 17 Aug 2017 00:16:39 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 8EA8E169E4A for ; Thu, 17 Aug 2017 02:16:38 +0200 (CEST) Received: (qmail 99332 invoked by uid 500); 17 Aug 2017 00:16:37 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 99321 invoked by uid 99); 17 Aug 2017 00:16:36 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Aug 2017 00:16:36 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 914D11807CA for ; Thu, 17 Aug 2017 00:16:36 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 3lz3n5kpbX9j for ; Thu, 17 Aug 2017 00:16:36 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id E4A555F3CF for ; Thu, 17 Aug 2017 00:16:35 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v7H0GYQ2008789; Thu, 17 Aug 2017 00:16:35 GMT Message-Id: <201708170016.v7H0GYQ2008789@ip-10-146-233-104.ec2.internal> Date: Thu, 17 Aug 2017 00:16:34 +0000 From: "Matthew Jacobs (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Dan Hecht , Tim Armstrong Reply-To: mj@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5644=3A_Reject_queries_if_min_reservation_is_too_large=0A?= X-Gerrit-Change-Id: Iabe87ce8f460356cfe4d1be4d7092c5900f9d79b X-Gerrit-ChangeURL: X-Gerrit-Commit: 93cb8ad87e338498faddeef6a6af11922c264415 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Thu, 17 Aug 2017 00:16:39 -0000 Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5644: Reject queries if min reservation is too large ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7678/2/be/src/scheduling/admission-controller.cc File be/src/scheduling/admission-controller.cc: Line 401: // Compute the max (over all backends) min_reservation_bytes and the cluster total > WFM. It seems helpful since it's not obvious otherwise that the profile wou Done -- To view, visit http://gerrit.cloudera.org:8080/7678 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iabe87ce8f460356cfe4d1be4d7092c5900f9d79b Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes