Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id EDAF2200CE6 for ; Thu, 17 Aug 2017 01:36:23 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id EC04E169DC1; Wed, 16 Aug 2017 23:36:23 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 3CD9D169DC0 for ; Thu, 17 Aug 2017 01:36:23 +0200 (CEST) Received: (qmail 6126 invoked by uid 500); 16 Aug 2017 23:36:22 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 6115 invoked by uid 99); 16 Aug 2017 23:36:21 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 16 Aug 2017 23:36:21 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 4FA28180707 for ; Wed, 16 Aug 2017 23:36:21 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 7rkThJMKs77T for ; Wed, 16 Aug 2017 23:36:20 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 5E6A45FBBA for ; Wed, 16 Aug 2017 23:36:20 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v7GNaIKF006673; Wed, 16 Aug 2017 23:36:18 GMT Message-Id: <201708162336.v7GNaIKF006673@ip-10-146-233-104.ec2.internal> Date: Wed, 16 Aug 2017 23:36:18 +0000 From: "Tim Armstrong (Code Review)" To: Tianyi Wang , impala-cr@cloudera.com, reviews@impala.incubator.apache.org Reply-To: tarmstrong@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5573=3A_Add_decimal_codegen_in_text_scanner=0A?= X-Gerrit-Change-Id: Ia65820e969d59094dc92d912a5279fa90f6b179d X-Gerrit-ChangeURL: X-Gerrit-Commit: d672e4588e84215335ee7d8654dd7265dc6dfe15 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Wed, 16 Aug 2017 23:36:24 -0000 Tim Armstrong has posted comments on this change. Change subject: IMPALA-5573: Add decimal codegen in text scanner ...................................................................... Patch Set 8: Code-Review+2 No problem -- To view, visit http://gerrit.cloudera.org:8080/7683 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia65820e969d59094dc92d912a5279fa90f6b179d Gerrit-PatchSet: 8 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tianyi Wang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tianyi Wang Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No