Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 9E259200CF8 for ; Wed, 16 Aug 2017 03:02:10 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 93C35167D7D; Wed, 16 Aug 2017 01:02:10 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D8A63167D62 for ; Wed, 16 Aug 2017 03:02:09 +0200 (CEST) Received: (qmail 69036 invoked by uid 500); 16 Aug 2017 01:02:09 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 69025 invoked by uid 99); 16 Aug 2017 01:02:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 16 Aug 2017 01:02:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 60802C093C for ; Wed, 16 Aug 2017 01:02:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id VYki9yPqW65L for ; Wed, 16 Aug 2017 01:02:07 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 9E1E55F520 for ; Wed, 16 Aug 2017 01:02:07 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v7G125V8010287; Wed, 16 Aug 2017 01:02:05 GMT Message-Id: <201708160102.v7G125V8010287@ip-10-146-233-104.ec2.internal> Date: Wed, 16 Aug 2017 01:02:05 +0000 From: "Dan Hecht (Code Review)" To: Tim Armstrong , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Jim Apple Reply-To: dhecht@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-2615=3A_support_=5B=5Bnodiscard=5D=5D_on_Status=0A?= X-Gerrit-Change-Id: I972543af2e9f98b12dcbb5479b4c1a7d53952197 X-Gerrit-ChangeURL: X-Gerrit-Commit: a6260d0566b5b6d32ac3bf66e59361092db6cf10 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Wed, 16 Aug 2017 01:02:10 -0000 Dan Hecht has posted comments on this change. Change subject: IMPALA-2615: support [[nodiscard]] on Status ...................................................................... Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/7253/9/be/src/util/runtime-profile.cc File be/src/util/runtime-profile.cc: Line 748: MakeScopeExitTrigger([&compressor]() { compressor->Close(); }); > I couldn't think of a great alternative. Putting Close() before every retur i prefer goto, but up to you. -- To view, visit http://gerrit.cloudera.org:8080/7253 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I972543af2e9f98b12dcbb5479b4c1a7d53952197 Gerrit-PatchSet: 9 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes