Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 75338200CF8 for ; Wed, 16 Aug 2017 00:19:17 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 741EA162D4B; Tue, 15 Aug 2017 22:19:17 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id BA6B4162C8C for ; Wed, 16 Aug 2017 00:19:16 +0200 (CEST) Received: (qmail 8804 invoked by uid 500); 15 Aug 2017 22:19:15 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 8792 invoked by uid 99); 15 Aug 2017 22:19:15 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Aug 2017 22:19:15 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 1D431180777 for ; Tue, 15 Aug 2017 22:19:15 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id NxRmRd3t_9st for ; Tue, 15 Aug 2017 22:19:14 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id BAFC45F6BF for ; Tue, 15 Aug 2017 22:19:13 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v7FMJBU9000560; Tue, 15 Aug 2017 22:19:11 GMT Message-Id: <201708152219.v7FMJBU9000560@ip-10-146-233-104.ec2.internal> Date: Tue, 15 Aug 2017 22:19:11 +0000 From: "Lars Volker (Code Review)" To: Tianyi Wang , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Sailesh Mukil , Michael Brown Reply-To: lv@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-992=3A_Rerun_past_queries_from_history_in_shell=0A?= X-Gerrit-Change-Id: Ifc28e8ce07845343267224c3b9ccb71b29a524d2 X-Gerrit-ChangeURL: X-Gerrit-Commit: 2969223a5fd2288c2998c27b1c71144c95968556 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Tue, 15 Aug 2017 22:19:17 -0000 Lars Volker has posted comments on this change. Change subject: IMPALA-992: Rerun past queries from history in shell ...................................................................... Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/#/c/7674/5//COMMIT_MSG Commit Message: Line 9: This patch adds a new command "rerun" and shortcut "@" to impala-shell. nit: and a shortcut. Line 10: User can rerun a certain query by its index given by history command. nit: users... PS5, Line 12: Negavie typo http://gerrit.cloudera.org:8080/#/c/7674/5/shell/impala_shell.py File shell/impala_shell.py: PS5, Line 1105: format I think this should be aligned with the . under the " according to PEP8. Line 1111: # Remove the semicolon at last. I think this comment now is not needed anymore, the command looks self explanatory enough to me. -- To view, visit http://gerrit.cloudera.org:8080/7674 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifc28e8ce07845343267224c3b9ccb71b29a524d2 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tianyi Wang Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Sailesh Mukil Gerrit-Reviewer: Tianyi Wang Gerrit-HasComments: Yes