Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id C88282004F3 for ; Tue, 15 Aug 2017 19:58:45 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id C72A816713C; Tue, 15 Aug 2017 17:58:45 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 1843B16713B for ; Tue, 15 Aug 2017 19:58:44 +0200 (CEST) Received: (qmail 37622 invoked by uid 500); 15 Aug 2017 17:58:42 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 37611 invoked by uid 99); 15 Aug 2017 17:58:42 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Aug 2017 17:58:42 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id DE5821A0B63 for ; Tue, 15 Aug 2017 17:58:41 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id ah0-QnvBwmkz for ; Tue, 15 Aug 2017 17:58:41 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 7EFCE5F6BF for ; Tue, 15 Aug 2017 17:58:40 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v7FHwcCo021699; Tue, 15 Aug 2017 17:58:38 GMT Message-Id: <201708151758.v7FHwcCo021699@ip-10-146-233-104.ec2.internal> Date: Tue, 15 Aug 2017 17:58:38 +0000 From: "Michael Brown (Code Review)" To: Tianyi Wang , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Sailesh Mukil , Lars Volker Reply-To: mikeb@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_Impala-992=3A_Rerun_past_queries_from_history_in_shell=0A?= X-Gerrit-Change-Id: Ifc28e8ce07845343267224c3b9ccb71b29a524d2 X-Gerrit-ChangeURL: X-Gerrit-Commit: ce85dd6a6f6e6e989b35e09a62266ae407e3b990 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Tue, 15 Aug 2017 17:58:46 -0000 Michael Brown has posted comments on this change. Change subject: Impala-992: Rerun past queries from history in shell ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7674/2/shell/impala_shell.py File shell/impala_shell.py: PS2, Line 1102: print_to_stderr("Command index out of range. Valid range: [1, {}]".format(history_length)) > long line Please use explicit indexing or kwarg-style format: "{}".format(str) is not Python 2.6-compatible. -- To view, visit http://gerrit.cloudera.org:8080/7674 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifc28e8ce07845343267224c3b9ccb71b29a524d2 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tianyi Wang Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Sailesh Mukil Gerrit-HasComments: Yes