Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Message-Id: <201708151536.v7FFaaDP016445@ip-10-146-233-104.ec2.internal>
Date: Tue, 15 Aug 2017 15:36:36 +0000
From: "Tim Armstrong (Code Review)" <gerrit@cloudera.org>
To: Henry Robinson <henry@cloudera.com>, impala-cr@cloudera.com,
        reviews@impala.incubator.apache.org
CC: Sailesh Mukil <sailesh@cloudera.com>
Reply-To: tarmstrong@cloudera.com
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5775=3A_Allow_shell_to_support_TLSv1=2C_v1=2E1_and_v1=2E2=0A?=
In-Reply-To: <gerrit.1502768020000.I5487f82d110676b9c3c7a5305931da00c7f68ca0@gerrit.cloudera.org>
References: <gerrit.1502768020000.I5487f82d110676b9c3c7a5305931da00c7f68ca0@gerrit.cloudera.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.12.7
archived-at: Tue, 15 Aug 2017 15:36:41 -0000

Tim Armstrong has posted comments on this change.

Change subject: IMPALA-5775: Allow shell to support TLSv1, v1.1 and v1.2
......................................................................


Patch Set 2:

(2 comments)

Looks good, just had minor comments.

http://gerrit.cloudera.org:8080/#/c/7675/2/shell/TSSLSocketWithWildcardSAN.py
File shell/TSSLSocketWithWildcardSAN.py:

Line 50:     self.SSL_VERSION = ssl.PROTOCOL_SSLv23
Maybe mention that TSSLSocket forwards self.SSL_VERSION to the wrap_socket argument of wrap_socket()? I guess it's implied but setting a "constant" is a bit of weird API so it took me a while to convince myself it worked.

FWIW it looks like they cleaned it up in THRIFT-3505 (Thrift 0.10.0)


http://gerrit.cloudera.org:8080/#/c/7675/2/tests/custom_cluster/test_client_ssl.py
File tests/custom_cluster/test_client_ssl.py:

Line 108:   @pytest.mark.xfail(run=True, reason="IMPALA-4295 on Centos6")
Can we xfail this more selectively if it's just an OS version issue? E.g. GVO runs on ubuntu 16 now.

This seems ok if a fix is imminent but otherwise the risk is that we never remove it from xfail.


-- 
To view, visit http://gerrit.cloudera.org:8080/7675
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5487f82d110676b9c3c7a5305931da00c7f68ca0
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes