Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 63F3B20049C for ; Fri, 11 Aug 2017 22:24:15 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 6233D16DFBB; Fri, 11 Aug 2017 20:24:15 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A8A3816DFBA for ; Fri, 11 Aug 2017 22:24:14 +0200 (CEST) Received: (qmail 58903 invoked by uid 500); 11 Aug 2017 20:24:13 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 58892 invoked by uid 99); 11 Aug 2017 20:24:13 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 11 Aug 2017 20:24:13 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 445581807ED for ; Fri, 11 Aug 2017 20:24:13 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 3_xkWUIKWbu3 for ; Fri, 11 Aug 2017 20:24:12 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id E24685F30C for ; Fri, 11 Aug 2017 20:24:11 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v7BKO9NK015202; Fri, 11 Aug 2017 20:24:09 GMT Message-Id: <201708112024.v7BKO9NK015202@ip-10-146-233-104.ec2.internal> Date: Fri, 11 Aug 2017 20:24:09 +0000 From: "Tianyi Wang (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Tim Armstrong Reply-To: twang@cloudera.com X-Gerrit-MessageType: newpatchset Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5327=3A_Handle_return_of_JNI_GetStringUTFChar=0A?= X-Gerrit-Change-Id: I47eed045f21c6ed3a8decf422ce8429fc66c4322 X-Gerrit-ChangeURL: X-Gerrit-Commit: 549a59ee5febe8471fe84cc2d132f6174f3c8bbd In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Fri, 11 Aug 2017 20:24:15 -0000 Tianyi Wang has uploaded a new patch set (#5). Change subject: IMPALA-5327: Handle return of JNI GetStringUTFChar ...................................................................... IMPALA-5327: Handle return of JNI GetStringUTFChar GetStringUTFChars may return NULL or throw exception and it is not handled in two places. This patch checks the return value/exception, logs if there is error and return error to the caller. A helper class JniUtfCharGuard is added to jni-util.h/cc to manage the lifetime. Change-Id: I47eed045f21c6ed3a8decf422ce8429fc66c4322 --- M be/src/common/status.h M be/src/util/jni-util.cc M be/src/util/jni-util.h M be/src/util/logging-support.cc 4 files changed, 68 insertions(+), 26 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/42/7642/5 -- To view, visit http://gerrit.cloudera.org:8080/7642 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I47eed045f21c6ed3a8decf422ce8429fc66c4322 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tianyi Wang Gerrit-Reviewer: Tianyi Wang Gerrit-Reviewer: Tim Armstrong