Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id E3BAB20049C for ; Fri, 11 Aug 2017 17:18:58 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id E21C516D626; Fri, 11 Aug 2017 15:18:58 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 3CF7D16D625 for ; Fri, 11 Aug 2017 17:18:58 +0200 (CEST) Received: (qmail 53377 invoked by uid 500); 11 Aug 2017 15:18:57 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 53347 invoked by uid 99); 11 Aug 2017 15:18:57 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 11 Aug 2017 15:18:57 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id C9284180816 for ; Fri, 11 Aug 2017 15:18:56 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id QvXhspyjXTzl for ; Fri, 11 Aug 2017 15:18:56 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 03FBA5FC72 for ; Fri, 11 Aug 2017 15:18:55 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v7BFItkU004627; Fri, 11 Aug 2017 15:18:55 GMT Message-Id: <201708111518.v7BFItkU004627@ip-10-146-233-104.ec2.internal> Date: Fri, 11 Aug 2017 15:18:55 +0000 From: "Tim Armstrong (Code Review)" To: Henry Robinson , impala-cr@cloudera.com, reviews@impala.incubator.apache.org Reply-To: tarmstrong@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5773=3A_Correctly_account_for_memory_used_in_data_stream_receiver_queue=0A?= X-Gerrit-Change-Id: I9e90f9596ee984438e3373af05e84d361702ca6a X-Gerrit-ChangeURL: X-Gerrit-Commit: ce2b9f1d14fc1de009ce26dc44773a0612ac9984 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Fri, 11 Aug 2017 15:18:59 -0000 Tim Armstrong has posted comments on this change. Change subject: IMPALA-5773: Correctly account for memory used in data stream receiver queue ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/7646/2/be/src/runtime/row-batch.cc File be/src/runtime/row-batch.cc: PS2, Line 344: int Needs to be an int64_t now PS2, Line 351: int Needs to be an int64_t now http://gerrit.cloudera.org:8080/#/c/7646/1/be/src/runtime/row-batch.h File be/src/runtime/row-batch.h: Line 304: /// deserialized form. If a row batch is compressed, its serialized size can be much > Done - not all serialized batches are compressed, so need to be a bit caref Good point. I think the new comment is helpful. -- To view, visit http://gerrit.cloudera.org:8080/7646 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e90f9596ee984438e3373af05e84d361702ca6a Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes