Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Message-Id: <201708102030.v7AKUngE016058@ip-10-146-233-104.ec2.internal>
Date: Thu, 10 Aug 2017 20:30:49 +0000
From: "Michael Ho (Code Review)" <gerrit@cloudera.org>
To: Henry Robinson <henry@cloudera.com>, impala-cr@cloudera.com,
        reviews@impala.incubator.apache.org
CC: Matthew Jacobs <mj@cloudera.com>
Reply-To: kwho@cloudera.com
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4669=3A_=5BSECURITY=5D_Add_security_library_to_build=0A?=
In-Reply-To: <gerrit.1484350425000.I4f327810066bee7f3ac107b0295480fb9ed45e14@gerrit.cloudera.org>
References: <gerrit.1484350425000.I4f327810066bee7f3ac107b0295480fb9ed45e14@gerrit.cloudera.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.12.7
archived-at: Thu, 10 Aug 2017 20:30:55 -0000

Michael Ho has posted comments on this change.

Change subject: IMPALA-4669: [SECURITY] Add security library to build
......................................................................


Patch Set 15:

(3 comments)

Change LGTM. I assume you have tested this with packaging build, right ?
Also, for the change in be/src/kudu/security/*, do you plan to make the same changes in Kudu code base if that's not done already ?

http://gerrit.cloudera.org:8080/#/c/5717/15/CMakeLists.txt
File CMakeLists.txt:

PS15, Line 159: set(OPENSSL_STATIC_LINKING ON)
This line should not exist, right ?


http://gerrit.cloudera.org:8080/#/c/5717/15/be/src/kudu/security/init.cc
File be/src/kudu/security/init.cc:

PS15, Line 351: #if defined(
nit: #ifdef to be consistent with #ifndef above. Feel free to ignore.


http://gerrit.cloudera.org:8080/#/c/5717/15/be/src/kudu/security/token_verifier.cc
File be/src/kudu/security/token_verifier.cc:

PS15, Line 160:   DCHECK(false);
              :   return nullptr;
Should this be done in the Kudu code base too or Impala is somehow different ?


-- 
To view, visit http://gerrit.cloudera.org:8080/5717
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4f327810066bee7f3ac107b0295480fb9ed45e14
Gerrit-PatchSet: 15
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-HasComments: Yes