Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id AE98A200CDE for ; Tue, 8 Aug 2017 12:23:37 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id AD2F6167044; Tue, 8 Aug 2017 10:23:37 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id F0F80167043 for ; Tue, 8 Aug 2017 12:23:36 +0200 (CEST) Received: (qmail 85875 invoked by uid 500); 8 Aug 2017 10:23:36 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 85864 invoked by uid 99); 8 Aug 2017 10:23:35 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 Aug 2017 10:23:35 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 834ACC0C29 for ; Tue, 8 Aug 2017 10:23:35 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id MGqPhAZhXa7W for ; Tue, 8 Aug 2017 10:23:31 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 42D8D5F666 for ; Tue, 8 Aug 2017 10:23:31 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v78ANUcR024678; Tue, 8 Aug 2017 10:23:30 GMT Message-Id: <201708081023.v78ANUcR024678@ip-10-146-233-104.ec2.internal> Date: Tue, 8 Aug 2017 10:23:30 +0000 From: "Impala Public Jenkins (Code Review)" To: Tianyi Wang , impala-cr@cloudera.com, reviews@impala.incubator.apache.org X-Gerrit-MessageType: merged Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5572=3A_Timestamp_codegen_for_text_scanner=0A?= X-Gerrit-Change-Id: I00cbf8ec7784ca9594e14e952f46dc54a5ede44b X-Gerrit-ChangeURL: X-Gerrit-Commit: d61065d6383ece19fdafd2526ecf00dab4e1f4d4 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Tue, 08 Aug 2017 10:23:37 -0000 Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5572: Timestamp codegen for text scanner ...................................................................... IMPALA-5572: Timestamp codegen for text scanner Currently codegen is disabled when scanning text tables with timestamp columns. The message is "Timestamp not yet supported for codegen." This patch adds support for timestamp codegen. A simple query in the comment section of this issue performs a little better (4%) than interpreted version. Testing: The patch passed test with exhaustive workload exploration strategy. Change-Id: I00cbf8ec7784ca9594e14e952f46dc54a5ede44b Reviewed-on: http://gerrit.cloudera.org:8080/7556 Reviewed-by: Tim Armstrong Tested-by: Impala Public Jenkins --- M be/src/codegen/gen_ir_descriptions.py M be/src/exec/hdfs-scanner-ir.cc M be/src/exec/hdfs-scanner.cc M be/src/exec/text-converter.cc M be/src/util/string-parser.h 5 files changed, 34 insertions(+), 6 deletions(-) Approvals: Impala Public Jenkins: Verified Tim Armstrong: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/7556 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I00cbf8ec7784ca9594e14e952f46dc54a5ede44b Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tianyi Wang Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tianyi Wang Gerrit-Reviewer: Tim Armstrong