Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id BF057200CDA for ; Fri, 4 Aug 2017 18:18:32 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id B8FE916C8D2; Fri, 4 Aug 2017 16:18:32 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 0674616C892 for ; Fri, 4 Aug 2017 18:18:31 +0200 (CEST) Received: (qmail 12301 invoked by uid 500); 4 Aug 2017 16:18:31 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 12289 invoked by uid 99); 4 Aug 2017 16:18:30 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 Aug 2017 16:18:30 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 8C0CBC0043 for ; Fri, 4 Aug 2017 16:18:30 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id Pbrd-LNCkvQj for ; Fri, 4 Aug 2017 16:18:29 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 76F345FDB5 for ; Fri, 4 Aug 2017 16:18:29 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v74GIQQF000883; Fri, 4 Aug 2017 16:18:26 GMT Message-Id: <201708041618.v74GIQQF000883@ip-10-146-233-104.ec2.internal> Date: Fri, 4 Aug 2017 16:18:26 +0000 From: "Matthew Jacobs (Code Review)" To: Zach Amsden , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Tim Armstrong , Jim Apple , David Knupp , Joe McDonnell Reply-To: mj@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5764=3A_Allow_overriding_packaged_components=0A?= X-Gerrit-Change-Id: I95c2662e6f62adc924cc5de7a371202126046545 X-Gerrit-ChangeURL: X-Gerrit-Commit: 71bcfa57c08216210741af56ae972900842d5231 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Fri, 04 Aug 2017 16:18:32 -0000 Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5764: Allow overriding packaged components ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7581/1/bin/impala-config.sh File bin/impala-config.sh: PS1, Line 131: cdh > Keeping it as cdh_components kind-of makes sense to me as long as we're put I see, if that's the use case that makes sense. It might be helpful to have a comment indicating how you might also include X_components. -- To view, visit http://gerrit.cloudera.org:8080/7581 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I95c2662e6f62adc924cc5de7a371202126046545 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes