Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Message-Id: <201708032236.v73MadhP016951@ip-10-146-233-104.ec2.internal>
Date: Thu, 3 Aug 2017 22:36:39 +0000
From: "Tim Armstrong (Code Review)" <gerrit@cloudera.org>
To: anujphadke <aphadke@cloudera.com>, impala-cr@cloudera.com,
        reviews@impala.incubator.apache.org
CC: Lars Volker <lv@cloudera.com>
Reply-To: tarmstrong@cloudera.com
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-2869=3A_Log_why_codegen_is_disabled_in_TextConverter=3A=3ACodegenWriteSlot=28=29=0A?=
In-Reply-To: <gerrit.1501743042000.I355efe2d5566ba6a1b72648763794a79c80c3089@gerrit.cloudera.org>
References: <gerrit.1501743042000.I355efe2d5566ba6a1b72648763794a79c80c3089@gerrit.cloudera.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.12.7
archived-at: Thu, 03 Aug 2017 22:36:44 -0000

Tim Armstrong has posted comments on this change.

Change subject: IMPALA-2869: Log why codegen is disabled in TextConverter::CodegenWriteSlot()
......................................................................


Patch Set 2:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/7574/2/be/src/exec/hdfs-scanner.cc
File be/src/exec/hdfs-scanner.cc:

PS2, Line 326: NULL
Switch to nullptr


http://gerrit.cloudera.org:8080/#/c/7574/1/be/src/exec/text-converter.cc
File be/src/exec/text-converter.cc:

Line 280:     Status("TextConverter::CodegenWriteSlot:codegen'd "
?


http://gerrit.cloudera.org:8080/#/c/7574/2/be/src/exec/text-converter.cc
File be/src/exec/text-converter.cc:

Line 76: //   %1 = bitcast <{ i32, i8 }>* %tuple_arg to i8*
> Why did the IR change?
Same question. I'm guessing that the old IR was just stale, in which case - thanks for updating.

There's a lot of stale IR in comments since we don't update all the comments in the dependency graph when we change a codegen function (or change the LLVM version).


Line 125:   if (is_null_string_fn == NULL) {
This could be a DCHECK. We shouldn't be missing builtin functions.


-- 
To view, visit http://gerrit.cloudera.org:8080/7574
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I355efe2d5566ba6a1b72648763794a79c80c3089
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: anujphadke <aphadke@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: anujphadke <aphadke@cloudera.com>
Gerrit-HasComments: Yes