Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 9CC70200CD9 for ; Thu, 3 Aug 2017 22:28:47 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 9B3A3169FC0; Thu, 3 Aug 2017 20:28:47 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E1610169F7B for ; Thu, 3 Aug 2017 22:28:46 +0200 (CEST) Received: (qmail 83452 invoked by uid 500); 3 Aug 2017 20:28:46 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 83436 invoked by uid 99); 3 Aug 2017 20:28:45 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Aug 2017 20:28:45 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 6CB651A09C5 for ; Thu, 3 Aug 2017 20:28:45 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id lFfNIOC7o1WW for ; Thu, 3 Aug 2017 20:28:44 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 84EFF5FD3D for ; Thu, 3 Aug 2017 20:28:44 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v73KShu5013121; Thu, 3 Aug 2017 20:28:43 GMT Message-Id: <201708032028.v73KShu5013121@ip-10-146-233-104.ec2.internal> Date: Thu, 3 Aug 2017 20:28:43 +0000 From: "Matthew Jacobs (Code Review)" To: Tim Armstrong , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Henry Robinson , Michael Ho Reply-To: mj@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5715=3A_=28mitigation_only=29_defer_destruction_of_MemTrackers=0A?= X-Gerrit-Change-Id: I205abb0076d1ffd08cb93c0f1671c8b81e7fba0f X-Gerrit-ChangeURL: X-Gerrit-Commit: c45ed93f40ad625295eda53f99f9ed7341eca1ed In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Thu, 03 Aug 2017 20:28:47 -0000 Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5715: (mitigation only) defer destruction of MemTrackers ...................................................................... Patch Set 2: > The conclusion was that it was very difficult to reason about the > lifetime of the different MemTrackers and the possible states > things could end up in during teardown. The original patch made a > small change that was difficult to reason about in isolation. > > This doesn't actually address the root cause of IMPALA-5715 - if we > figure out what happened there we could probably do a targeted fix. Yup I agree this makes it much easier to reason about. Thanks. -- To view, visit http://gerrit.cloudera.org:8080/7492 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I205abb0076d1ffd08cb93c0f1671c8b81e7fba0f Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No