Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D2372200CD9 for ; Thu, 3 Aug 2017 21:06:05 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id D0AD816C561; Thu, 3 Aug 2017 19:06:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 1F9FB16C55F for ; Thu, 3 Aug 2017 21:06:04 +0200 (CEST) Received: (qmail 2598 invoked by uid 500); 3 Aug 2017 19:06:04 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 2587 invoked by uid 99); 3 Aug 2017 19:06:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Aug 2017 19:06:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id B021CC1DE6 for ; Thu, 3 Aug 2017 19:06:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id qRwQeCGs5ttE for ; Thu, 3 Aug 2017 19:05:55 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id F3D845F6C8 for ; Thu, 3 Aug 2017 19:05:54 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v73J5qri010533; Thu, 3 Aug 2017 19:05:52 GMT Message-Id: <201708031905.v73J5qri010533@ip-10-146-233-104.ec2.internal> Date: Thu, 3 Aug 2017 19:05:52 +0000 From: "Tim Armstrong (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Henry Robinson , Michael Ho , Matthew Jacobs Reply-To: tarmstrong@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5715=3A_=28mitigation_only=29_defer_destruction_of_MemTrackers=0A?= X-Gerrit-Change-Id: I205abb0076d1ffd08cb93c0f1671c8b81e7fba0f X-Gerrit-ChangeURL: X-Gerrit-Commit: c45ed93f40ad625295eda53f99f9ed7341eca1ed In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Thu, 03 Aug 2017 19:06:06 -0000 Tim Armstrong has posted comments on this change. Change subject: IMPALA-5715: (mitigation only) defer destruction of MemTrackers ...................................................................... Patch Set 2: The conclusion was that it was very difficult to reason about the lifetime of the different MemTrackers and the possible states things could end up in during teardown. The original patch made a small change that was difficult to reason about in isolation. This doesn't actually address the root cause of IMPALA-5715 - if we figure out what happened there we could probably do a targeted fix. -- To view, visit http://gerrit.cloudera.org:8080/7492 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I205abb0076d1ffd08cb93c0f1671c8b81e7fba0f Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No