Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id E5397200CD9 for ; Thu, 3 Aug 2017 19:28:48 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id E3AFC16C193; Thu, 3 Aug 2017 17:28:48 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 34A3316C192 for ; Thu, 3 Aug 2017 19:28:48 +0200 (CEST) Received: (qmail 96132 invoked by uid 500); 3 Aug 2017 17:28:47 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 96120 invoked by uid 99); 3 Aug 2017 17:28:47 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Aug 2017 17:28:47 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id AD7B1C1BAA for ; Thu, 3 Aug 2017 17:28:46 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id JXgqcEX7wD6l for ; Thu, 3 Aug 2017 17:28:33 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 64D8B5F6C3 for ; Thu, 3 Aug 2017 17:28:33 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v73HSWVu005631; Thu, 3 Aug 2017 17:28:32 GMT Message-Id: <201708031728.v73HSWVu005631@ip-10-146-233-104.ec2.internal> Date: Thu, 3 Aug 2017 17:28:32 +0000 From: "Impala Public Jenkins (Code Review)" To: Tim Armstrong , impala-cr@cloudera.com, reviews@impala.incubator.apache.org X-Gerrit-MessageType: merged Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5756=3A_start_memory_maintenance_thread_after_metric_creation=0A?= X-Gerrit-Change-Id: Ibb7337a68547b4d660f3100b04df2c20befb044c X-Gerrit-ChangeURL: X-Gerrit-Commit: 79205bb3307a48cdfe62a8a5ccd4c78b93d2ecef In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Thu, 03 Aug 2017 17:28:49 -0000 Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5756: start memory maintenance thread after metric creation ...................................................................... IMPALA-5756: start memory maintenance thread after metric creation Daemons were sometimes crashing on startup if the memory maintenance thread started running before the memory metrics were created. This changes the startup sequence so that the thread is started after the metrics are registered. Change-Id: Ibb7337a68547b4d660f3100b04df2c20befb044c Reviewed-on: http://gerrit.cloudera.org:8080/7573 Reviewed-by: Henry Robinson Tested-by: Impala Public Jenkins --- M be/src/catalog/catalogd-main.cc M be/src/common/init.cc M be/src/common/init.h M be/src/service/impalad-main.cc M be/src/statestore/statestored-main.cc 5 files changed, 13 insertions(+), 8 deletions(-) Approvals: Impala Public Jenkins: Verified Henry Robinson: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/7573 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb7337a68547b4d660f3100b04df2c20befb044c Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong