Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Message-Id: <201708030459.v734x18A028518@ip-10-146-233-104.ec2.internal>
Date: Thu, 3 Aug 2017 04:59:01 +0000
From: "Henry Robinson (Code Review)" <gerrit@cloudera.org>
To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org
CC: Sailesh Mukil <sailesh@cloudera.com>
Reply-To: henry@cloudera.com
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5742=3A_De-allocate_buffer_in_parquet-reader_on_exit=0A?=
In-Reply-To: <gerrit.1501734135000.Iedf163f858b42d2ca63a7a65d6e457539de59ab9@gerrit.cloudera.org>
References: <gerrit.1501734135000.Iedf163f858b42d2ca63a7a65d6e457539de59ab9@gerrit.cloudera.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.12.7
archived-at: Thu, 03 Aug 2017 04:59:07 -0000

Henry Robinson has posted comments on this change.

Change subject: IMPALA-5742: De-allocate buffer in parquet-reader on exit
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7572/1/be/src/util/parquet-reader.cc
File be/src/util/parquet-reader.cc:

PS1, Line 297:      << "  Metadata size: " << metadata_len << "(" << (metadata_len / (double)file_len)
             :      << ")" << endl
             :      << "  Total page header size: " << total_page_header_size << "("
             :      << (total_page_header_size / (double)file_len) << ")" << endl;
             :   ss << "  Column compressed size: " << total_compressed_data_size << "("
             :      << (total_compressed_data_size / (double)file_len) << ")" << endl;
             :   ss << "  Column uncompressed size: " << total_uncompressed_data_size << "("
             :      << compression_ratio << ")" << endl;
             :   for (int i = 0; i < column_byte_sizes.size(); ++i) {
             :     ss << "    "
             :        << "Col " << i << ": " << column_byte_sizes[i] << "("
             :        << (column_byte_sizes[i] / (double)file_len) << ")" << endl;
> nit: Why change this formatting? The way it already was seems easier to rea
You're probably right, I just let clang-format do its thing. I'll revert.


-- 
To view, visit http://gerrit.cloudera.org:8080/7572
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iedf163f858b42d2ca63a7a65d6e457539de59ab9
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-HasComments: Yes