Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id A8011200CD8 for ; Wed, 2 Aug 2017 21:03:58 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id A6626169E10; Wed, 2 Aug 2017 19:03:58 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id ED0CD169E0E for ; Wed, 2 Aug 2017 21:03:57 +0200 (CEST) Received: (qmail 80322 invoked by uid 500); 2 Aug 2017 19:03:57 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 80311 invoked by uid 99); 2 Aug 2017 19:03:56 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Aug 2017 19:03:56 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 7C6E2C0221 for ; Wed, 2 Aug 2017 19:03:56 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id e1tBqEL4D4MH for ; Wed, 2 Aug 2017 19:03:55 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 4EC275FDB2 for ; Wed, 2 Aug 2017 19:03:55 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v72J3rbK010599; Wed, 2 Aug 2017 19:03:53 GMT Message-Id: <201708021903.v72J3rbK010599@ip-10-146-233-104.ec2.internal> Date: Wed, 2 Aug 2017 19:03:53 +0000 From: "Tianyi Wang (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Greg Rahn , Matthew Jacobs , Tim Armstrong Reply-To: twang@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-3894=3A_Change_the_behavior_parsing_date_=22YY=22=0A?= X-Gerrit-Change-Id: I5da761255915dc741f1dcc488fd4ef6ecc385896 X-Gerrit-ChangeURL: X-Gerrit-Commit: 47e754918223da369c9efdde0dd391fdb504f67a In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Wed, 02 Aug 2017 19:03:58 -0000 Tianyi Wang has posted comments on this change. Change subject: IMPALA-3894: Change the behavior parsing date "YY" ...................................................................... Patch Set 13: (1 comment) http://gerrit.cloudera.org:8080/#/c/7530/13/be/src/runtime/timestamp-parse-util.h File be/src/runtime/timestamp-parse-util.h: PS13, Line 141: /// The year of century_start_time. : boost::gregorian::date::year_type century_start_year; > why store this instead of using ptime.date().year() ? I think that shouldn' I did not look at the implementation of ptime and mistook it as a integer. -- To view, visit http://gerrit.cloudera.org:8080/7530 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5da761255915dc741f1dcc488fd4ef6ecc385896 Gerrit-PatchSet: 13 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tianyi Wang Gerrit-Reviewer: Greg Rahn Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Tianyi Wang Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes