Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Message-Id: <201708012208.v71M8ph6015472@ip-10-146-233-104.ec2.internal>
Date: Tue, 1 Aug 2017 22:08:51 +0000
From: "John Sherman (Code Review)" <gerrit@cloudera.org>
To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org
CC: Sailesh Mukil <sailesh@cloudera.com>, Henry Robinson <henry@cloudera.com>,
        Matthew Jacobs <mj@cloudera.com>, Dan Hecht <dhecht@cloudera.com>
Reply-To: jfs@arcadiadata.com
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5394=3A_Handle_blocked_HS2_connections=0A?=
In-Reply-To: <gerrit.1496426620000.I56a5f3d9cf931cff14eae7f236fea018236a6255@gerrit.cloudera.org>
References: <gerrit.1496426620000.I56a5f3d9cf931cff14eae7f236fea018236a6255@gerrit.cloudera.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.12.7
archived-at: Tue, 01 Aug 2017 22:08:55 -0000

John Sherman has posted comments on this change.

Change subject: IMPALA-5394: Handle blocked HS2 connections
......................................................................


Patch Set 4:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/7061/4/be/src/service/impala-server.cc
File be/src/service/impala-server.cc:

PS4, Line 1963: exec_env->metrics(), FLAGS_fe_service_threads, ThriftServer::ThreadPool);
> Let's make this change for beeswax as well.
Running this change through run-all-tests and changing the comment at 1954 to be:
"ODBC and Hue drivers do not support non-blocking servers." similar to the comment at line 1976. I'm guessing at the intent of the old comment.

After this change the only thing using ThreadPool server implementation is network-perf-benchmark.cc

Not sure what the network-perf-benchmark.cc is used for, but if nothing else is using ThreadedPool implementation should I just remove support for it from ThriftServer() to prevent bit rot in the unused code paths? Or just leave it be for future use (or just for the network-perf-benchmark to use?)


PS4, Line 1985: Threaded
> Maybe we can just remove Threaded and ThreadPool and just pass in the numbe
Does it matter that FLAG_enable_accept_queue_server can be turned to false and that these thread limits will not be enforced? Or at this point is there enough confidence that the accept_queue_server is good/stable enough and won't be disabled? If that is the case, should the flag be deprecated and the special case code be removed for disabling it?


-- 
To view, visit http://gerrit.cloudera.org:8080/7061
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I56a5f3d9cf931cff14eae7f236fea018236a6255
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Sherman <jfs@arcadiadata.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: John Sherman <jfs@arcadiadata.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-HasComments: Yes