impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bharath Vissapragada (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5881: Use TCompactProtocol for getAllCatalogObjects() call
Date Thu, 31 Aug 2017 23:58:36 GMT
Bharath Vissapragada has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7930

Change subject: IMPALA-5881: Use TCompactProtocol for getAllCatalogObjects() call
......................................................................

IMPALA-5881: Use TCompactProtocol for getAllCatalogObjects() call

This patch switches to using TCompactProtocol in getAllCatalogObjects()
when 'compact_catalog_topic' is true. Without the patch we only do that
for serialization between the statestore and the impalad, but not in the
Catalog JVM where the catalog topic updates are built.

In a heavily loaded cluster, serializing the topic update can hit JVM
array limits and using the compact protocol can alleviate the pressure to
some extent.

Eventually, we need to switch all the serialization paths to use the
TCompactProtocol but that is a more involved change and requires more
testing.

Change-Id: Iea371908d4248e087d69b31c5d6c2e07f577290d
---
M be/src/catalog/catalog.cc
M be/src/rpc/jni-thrift-util.h
M be/src/util/backend-gflag-util.cc
M common/thrift/BackendGflags.thrift
M fe/src/main/java/org/apache/impala/service/JniCatalog.java
5 files changed, 26 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/30/7930/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7930
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iea371908d4248e087d69b31c5d6c2e07f577290d
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada <bharathv@cloudera.com>

Mime
View raw message