impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tianyi Wang (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5425: Add test for validating input when setting query options
Date Thu, 24 Aug 2017 19:47:45 GMT
Tianyi Wang has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7805

Change subject: IMPALA-5425: Add test for validating input when setting query options
......................................................................

IMPALA-5425: Add test for validating input when setting query options

This patch adds a test case file
testdata/workloads/functional-query/queries/QueryTest/query_options_validation.test
The test cases include parsing edge cases, bondary values, special
cases for some options and some testcases moved from
testdata/workloads/functional-query/queries/QueryTest/set.test
and
be/src/service/query-options-test.cc
This patch also fixes a bug in generating error message string for one
query option.

Change-Id: I510e02bb0776673d8cbfc22b903831882c6908d7
---
M be/src/service/query-options-test.cc
M be/src/service/query-options.cc
A testdata/workloads/functional-query/queries/QueryTest/query_options_validation.test
M testdata/workloads/functional-query/queries/QueryTest/set.test
M tests/query_test/test_query_opts.py
5 files changed, 360 insertions(+), 130 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/05/7805/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7805
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I510e02bb0776673d8cbfc22b903831882c6908d7
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tianyi Wang <twang@cloudera.com>

Mime
View raw message