impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <>
Subject [Impala-ASF-CR] KUDU-2091: Certificates with intermediate CA's do not work with Kudu
Date Sun, 20 Aug 2017 01:11:59 GMT
Hello Todd Lipcon,

I'd like you to do a code review.  Please visit

to review the following change.

Change subject: KUDU-2091: Certificates with intermediate CA's do not work with Kudu

KUDU-2091: Certificates with intermediate CA's do not work with Kudu

Kudu previously did not recognize chain certificates. This patch
enables support for chain certificates by changing the Cert class'
underlying data type to STACK_OF(X509) instead of just X509.

STACK_OF(X509) allows multiple certificates to be held by the same
pointer. When we are presented with a file or a string that contains
multiple X509 certificates, they will be stored inside this
STACK_OF(X509) object.

When we call AddTrustedCertificate(Cert&), we iterate through the
STACK_OF(X509) contained in the Cert and add each one individually to
the X509_STORE for later verification.

Currently, IPKI does not make use of this ability and still works
with single certificates. DCHECKS are added to make sure that multiple
X509 certificates are not accidentally added to a Cert object.
Although this patch provides a general framework to use chain
certificates, if we want to use IPKI with chain certificates,
additional functionality will need to be added with clearer APIs.

External PKI makes use of this ability to add a chain CA if necessary.

Testing: A new test is added to rpc-test that uses a chain CA. This
test does not work without this patch.

Change-Id: I7334a5b2f1643848152562bbb1dee27b5290e83f
Reviewed-by: Todd Lipcon <>
Tested-by: Todd Lipcon <>
M be/src/kudu/rpc/
M be/src/kudu/security/ca/
M be/src/kudu/security/
M be/src/kudu/security/cert.h
M be/src/kudu/security/
M be/src/kudu/security/openssl_util.h
M be/src/kudu/security/test/
M be/src/kudu/security/test/test_certs.h
M be/src/kudu/security/
M be/src/kudu/security/
10 files changed, 431 insertions(+), 55 deletions(-)

  git pull ssh:// refs/changes/46/7746/1
To view, visit
To unsubscribe, visit

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7334a5b2f1643848152562bbb1dee27b5290e83f
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <>
Gerrit-Reviewer: Todd Lipcon <>

View raw message